D17426: [effects] Drop static_cast in getMainWindows

[Vlad Zagorodniy]

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
We use a function template, so static_cast in getMainWindows looks out
of place. Also, it's not good idea to do static_cast based on output of
isDeleted().

TEST PLAN
The Dialog Parent effect works.

REPOSITORY
R108 KWin

BRANCH
simplify-effectwindowimpl-mainwindows

REVISION DETAIL
https://phabricator.kde.org/D17426

AFFECTED FILES
effects.cpp

To: zzag, #kwin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

[Martin Flöser]

graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
R108 KWin

BRANCH
simplify-effectwindowimpl-mainwindows

REVISION DETAIL
https://phabricator.kde.org/D17426

To: zzag, #kwin, graesslin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

[Vlad Zagorodniy]

zzag added a comment.


@graesslin Can I land this revision? Or I should wait until all tests pass again?

REPOSITORY
R108 KWin

BRANCH
simplify-effectwindowimpl-mainwindows

REVISION DETAIL
https://phabricator.kde.org/D17426

To: zzag, #kwin, graesslin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

[Martin Flöser]

graesslin added a comment.

Post by Vlad Zagorodniy
@graesslin Can I land this revision? Or I should wait until all tests pass again?

For my own outstanding patches I decided to wait till the tests pass again.

REPOSITORY
R108 KWin

BRANCH
simplify-effectwindowimpl-mainwindows

REVISION DETAIL
https://phabricator.kde.org/D17426

To: zzag, #kwin, graesslin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart