Bellegarde Cédric
2012-03-19 10:23:51 UTC
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin:
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git
Kubuntu and ArchLinux packages (KDE 4.8.1 backport) availables here:
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
It looks like this:
I remove ( Loading Image... ) this way to show menu button because:
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 1147864
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin:
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git
Kubuntu and ArchLinux packages (KDE 4.8.1 backport) availables here:
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
It looks like this:
I remove ( Loading Image... ) this way to show menu button because:
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 1147864
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric