D17380: Avoid deleting ourselves midway through updateShadow

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
If updating a shadow means that there should be no shadow, shadow ends
up deleting itself midway through the method.

It's cleaner and safer to leave that to the caller.

This new change matches the existing documentation for
Shadow::updateShadow which states

In that case the owner should delete the Shadow.

TEST PLAN
Created an ASAN of kwin
Relevant testMaximised no longer fails

REPOSITORY
R108 KWin

BRANCH
origin-master (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17380

AFFECTED FILES
shadow.cpp
toplevel.cpp

To: davidedmundson, #kwin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

[Vlad Zagorodniy]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
R108 KWin

BRANCH
origin-master (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17380

To: davidedmundson, #kwin, zzag
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:576c6671245c: Avoid deleting ourselves midway through updateShadow (authored by davidedmundson).

CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D17380?vs=46952&id=46954#toc

REPOSITORY
R108 KWin

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17380?vs=46952&id=46954

REVISION DETAIL
https://phabricator.kde.org/D17380

AFFECTED FILES
shadow.cpp
toplevel.cpp

To: davidedmundson, #kwin, zzag
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart