Discussion:
Review Request: Add appmenu support to kwin
(too old to reply)
Bellegarde Cédric
2012-03-19 10:23:51 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

Review request for kwin.


Description
-------

Here a patch to add appmenu support to kwin:
- via a menu button in titlebar
- via a global shortcut

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

Kubuntu and ArchLinux packages (KDE 4.8.1 backport) availables here:
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583

It looks like this:


I remove ( Loading Image... ) this way to show menu button because:
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad


Diffs
-----

kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 1147864
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Bellegarde Cédric
2012-03-20 15:09:33 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated March 20, 2012, 3:09 p.m.)


Review request for kwin.


Changes
-------

- Fix button state (signal was connected on wrong client)
- Activate window when showing menu
- Fix Gimp menubar


Description
-------

Here a patch to add appmenu support to kwin:
- via a menu button in titlebar
- via a global shortcut

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

Kubuntu and ArchLinux packages (KDE 4.8.1 backport) availables here:
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583

It looks like this:
http://youtu.be/j0o1sRLRc60

I remove ( http://kde-look.org/CONTENT/content-pre1/141254-1.png ) this way to show menu button because:
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad


Diffs (updated)
-----

kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 1147864
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Bellegarde Cédric
2012-03-20 15:20:18 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated March 20, 2012, 3:20 p.m.)


Review request for kwin.


Changes
-------

Add missing menubar.h/menubar.cpp


Description
-------

Here a patch to add appmenu support to kwin:
- via a menu button in titlebar
- via a global shortcut

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

Kubuntu and ArchLinux packages (KDE 4.8.1 backport) availables here:
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583

It looks like this:
http://youtu.be/j0o1sRLRc60

I remove ( http://kde-look.org/CONTENT/content-pre1/141254-1.png ) this way to show menu button because:
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad


Diffs (updated)
-----

kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 1147864
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Bellegarde Cédric
2012-03-20 15:25:02 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated March 20, 2012, 3:25 p.m.)


Review request for kwin.


Changes
-------

I'm a dumb git user :-/ Hope files are here now....


Description
-------

Here a patch to add appmenu support to kwin:
- via a menu button in titlebar
- via a global shortcut

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

Kubuntu and ArchLinux packages (KDE 4.8.1 backport) availables here:
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583

It looks like this:
http://youtu.be/j0o1sRLRc60

I remove ( http://kde-look.org/CONTENT/content-pre1/141254-1.png ) this way to show menu button because:
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad


Diffs (updated)
-----

kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 1147864
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Martin Gräßlin
2012-03-20 16:34:06 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11657
-----------------------------------------------------------


First of all: I have not yet tested it and the current review is just based on reading through the diff.

To start with I have a few questions and general comments:
* Has the licencing issue been resolved? I see the MenuBar has now a GPLv2+ licence. Is this correct?
* The appmenu-kde will go into kde-workspace? That is will the CMakeCheck just work like that?
* the two neewly added code files do not follow our coding style. The header looks slightly different to our other headers and our variable name scheme is m_camelCase. It would be nice if that could be aligned.
* Obviously I cannot comment on Oxygen decoration, please get a review by Hugo for that part
* Are there any plans for Aurorae support or should I add it myself?
* As far as I have seen this will not cause any ABI problems in the decoration API. Is that correct or did I miss something?

Overall from reading through the diff it seems to be quite clean and looks good. Thanks for the work :-)


kwin/kcmkwin/kwindecoration/buttons.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9252>

could you please use an i18nc call to give some context to our translators. I guess they could have a hard time to figure out the difference between Window and Application Menu



kwin/kcmkwin/kwinoptions/windows.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9254>

Do you think this is the perfect place for it? I'm not sure, but would say it belongs more into the Workspace Behavior KCM. I would suggest to discuss this point on maybe plasma-***@kde.org to figure out where we put it.



kwin/libkdecorations/kcommondecoration.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9255>

best add also the same i18nc here



kwin/options.h
<http://git.reviewboard.kde.org/r/104344/#comment9246>

Options changed to have all variables private, a public getter and a Q_PROPERTY.

Personally I don't like "magic" values. What do you think about:
bool m_applicationMenuEnabled;
Qt::Orientation m_applicationMenuOrientation;



kwin/useractions.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9247>

please do a better ordering: "menubar.h" together with the other KWin includes and appmenu into the "dependency sections"



kwin/workspace.h
<http://git.reviewboard.kde.org/r/104344/#comment9248>

Please forward this slot also in scripting/workspace_proxy.(h|cpp)



kwin/workspace.h
<http://git.reviewboard.kde.org/r/104344/#comment9258>

These two methods have a too generic name. It is not clear what got (un)registered. Could you please add some hint that it is about the application menu.



kwin/workspace.h
<http://git.reviewboard.kde.org/r/104344/#comment9257>

why is the registrarClient inside Workspace? Wouldn't it make sense to have it in MenuBar? If it has to stay in Workspace the name should be changed to indicate that it is about the applicationMenu.



kwin/workspace.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9249>

*cough* :-)



kwin/workspace.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9250>

*cough* :-)



kwin/workspace.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9251>

Please move the documentation into the header. In general we tend to have the docs inside the header as the implementation might be split over many files.


- Martin GrÀßlin
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 20, 2012, 3:25 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 1147864
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-03-21 12:07:34 UTC
Permalink
Post by Bellegarde Cédric
kwin/options.h, lines 326-327
<http://git.reviewboard.kde.org/r/104344/diff/4/?file=53991#file53991line326>
Options changed to have all variables private, a public getter and a Q_PROPERTY.
bool m_applicationMenuEnabled;
Qt::Orientation m_applicationMenuOrientation;
Lionel tell me an enum should be better as we may extend menu types in future...

For the variable public, WTF i've done :)
Post by Bellegarde Cédric
kwin/workspace.h, line 913
<http://git.reviewboard.kde.org/r/104344/diff/4/?file=53994#file53994line913>
why is the registrarClient inside Workspace? Wouldn't it make sense to have it in MenuBar? If it has to stay in Workspace the name should be changed to indicate that it is about the applicationMenu.
registratClient is in workspace because:
- it need to be registered at kwin startup, not when showing menubar
- vertical menu do not have any menubar


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11657
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 20, 2012, 3:25 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 1147864
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-03-21 12:12:32 UTC
Permalink
Post by Martin Gräßlin
Post by Martin Gräßlin
First of all: I have not yet tested it and the current review is just based on reading through the diff.
* Has the licencing issue been resolved? I see the MenuBar has now a GPLv2+ licence. Is this correct?
* The appmenu-kde will go into kde-workspace? That is will the CMakeCheck just work like that?
* the two neewly added code files do not follow our coding style. The header looks slightly different to our other headers and our variable name scheme is m_camelCase. It would be nice if that could be aligned.
* Obviously I cannot comment on Oxygen decoration, please get a review by Hugo for that part
* Are there any plans for Aurorae support or should I add it myself?
* As far as I have seen this will not cause any ABI problems in the decoration API. Is that correct or did I miss something?
Overall from reading through the diff it seems to be quite clean and looks good. Thanks for the work :-)
Has the licencing issue been resolved? I see the MenuBar has now a GPLv2+ licence. Is this correct?
The licence issue comes from libkdecoration and original patch, now, all was moved to appmenu module, so no problems...
Post by Martin Gräßlin
The appmenu-kde will go into kde-workspace?
It should... Not sure for CMakeCheck, Lionel ?
Post by Martin Gräßlin
the two neewly added code files do not follow our coding style.
Going to fix this
Post by Martin Gräßlin
Are there any plans for Aurorae support or should I add it myself?
Maybe Lionel will have time soon for this, Lionel ?
Post by Martin Gräßlin
As far as I have seen this will not cause any ABI problems
As far as i know, this will not cause any ABI problems


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11657
-----------------------------------------------------------
Post by Martin Gräßlin
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 20, 2012, 3:25 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 1147864
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Thomas Lübking
2012-03-21 17:51:11 UTC
Permalink
Post by Bellegarde Cédric
kwin/options.h, lines 326-327
<http://git.reviewboard.kde.org/r/104344/diff/4/?file=53991#file53991line326>
Options changed to have all variables private, a public getter and a Q_PROPERTY.
bool m_applicationMenuEnabled;
Qt::Orientation m_applicationMenuOrientation;
Lionel tell me an enum should be better as we may extend menu types in future...
For the variable public, WTF i've done :)
Is the order used anywhere else?
Otherwwise Qt::Orientation would be sufficient, but it has Qt::Horizontal == 0x1 and Qt::Vertical == 0x2
Post by Bellegarde Cédric
kwin/workspace.h, line 913
<http://git.reviewboard.kde.org/r/104344/diff/4/?file=53994#file53994line913>
why is the registrarClient inside Workspace? Wouldn't it make sense to have it in MenuBar? If it has to stay in Workspace the name should be changed to indicate that it is about the applicationMenu.
- it need to be registered at kwin startup, not when showing menubar
- vertical menu do not have any menubar
Any chance to still change the classname?
"RegistrarClient" (w/o namespace?) in sth. that is apparently a lib sounds far to generic to me. Why isn't the class named eg. ApplicationMenuImporter?


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11657
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 21, 2012, 2:50 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/scripting/workspace_wrapper.h 0b44b6e
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-03-21 14:50:11 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated March 21, 2012, 2:50 p.m.)


Review request for kwin.


Changes
-------

- Fix issues reported by Martin, give a look at options.cpp and window.cpp, i'm not sure what i'm doing is the right way
- Add support for accelerators: it works only in Gtk application, dbusmenu-qt/appmenu-qt seems to be broken


Description
-------

Here a patch to add appmenu support to kwin:
- via a menu button in titlebar
- via a global shortcut

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

Kubuntu and ArchLinux packages (KDE 4.8.1 backport) availables here:
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583

It looks like this:
http://youtu.be/j0o1sRLRc60

I remove ( http://kde-look.org/CONTENT/content-pre1/141254-1.png ) this way to show menu button because:
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad


Diffs (updated)
-----

kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/scripting/workspace_wrapper.h 0b44b6e
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Martin Gräßlin
2012-03-22 06:49:31 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11734
-----------------------------------------------------------


One more general thing: could you add a build option for it. I think app-menu is rather unused in Plasma Active or if KWin is built without window decoration support, so a build option makes sense.

Have a look at some other features wrapped in build options like e.g. tiling.


kwin/client.h
<http://git.reviewboard.kde.org/r/104344/#comment9312>

why is this needed? We don't have something like that for the normal menu.



kwin/options.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9311>

could we get kdelibs coding style please :-) There are a few more cases like that.


- Martin GrÀßlin
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 21, 2012, 2:50 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/scripting/workspace_wrapper.h 0b44b6e
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-03-22 07:28:22 UTC
Permalink
Post by Bellegarde Cédric
kwin/client.h, lines 594-596
<http://git.reviewboard.kde.org/r/104344/diff/5/?file=54066#file54066line594>
why is this needed? We don't have something like that for the normal menu.
We need to this to get button position when calling menu via shortcut. Window menu always popup on left side...

We can disable this code if you thinks it's not needed.


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11734
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 21, 2012, 2:50 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/scripting/workspace_wrapper.h 0b44b6e
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-03-22 07:30:50 UTC
Permalink
Post by Bellegarde Cédric
kwin/options.cpp, lines 422-424
<http://git.reviewboard.kde.org/r/104344/diff/5/?file=54088#file54088line422>
could we get kdelibs coding style please :-) There are a few more cases like that.
Hmm, i just copy Options::MouseWheelCommand Options::mouseWheelCommand(const QString &name) code.


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11734
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 21, 2012, 2:50 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/scripting/workspace_wrapper.h 0b44b6e
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Thomas Lübking
2012-03-22 17:47:27 UTC
Permalink
Post by Bellegarde Cédric
kwin/client.h, lines 594-596
<http://git.reviewboard.kde.org/r/104344/diff/5/?file=54066#file54066line594>
why is this needed? We don't have something like that for the normal menu.
We need to this to get button position when calling menu via shortcut. Window menu always popup on left side...
We can disable this code if you thinks it's not needed.
The better approach was to let the deco suggest the popup position, yesno?
I mean, the menu could just be in the center or on the bottom or where not else.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11734
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 21, 2012, 2:50 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/scripting/workspace_wrapper.h 0b44b6e
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-03-26 13:56:55 UTC
Permalink
Post by Bellegarde Cédric
kwin/client.h, lines 594-596
<http://git.reviewboard.kde.org/r/104344/diff/5/?file=54066#file54066line594>
why is this needed? We don't have something like that for the normal menu.
We need to this to get button position when calling menu via shortcut. Window menu always popup on left side...
We can disable this code if you thinks it's not needed.
The better approach was to let the deco suggest the popup position, yesno?
I mean, the menu could just be in the center or on the bottom or where not else.
The deco can't tell use where button is or i don't know how to call KCommonDecoration::func() from Client::

Window Menu simply ignore button position and always popup on left, i can't follow this behaviour....


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11734
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 21, 2012, 2:50 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/scripting/workspace_wrapper.h 0b44b6e
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Thomas Lübking
2012-03-26 17:53:36 UTC
Permalink
Post by Bellegarde Cédric
kwin/client.h, lines 594-596
<http://git.reviewboard.kde.org/r/104344/diff/5/?file=54066#file54066line594>
why is this needed? We don't have something like that for the normal menu.
We need to this to get button position when calling menu via shortcut. Window menu always popup on left side...
We can disable this code if you thinks it's not needed.
The better approach was to let the deco suggest the popup position, yesno?
I mean, the menu could just be in the center or on the bottom or where not else.
Window Menu simply ignore button position and always popup on left, i can't follow this behaviour....
We're about to break deco ABI anyway.
However, other methods would be to
- have the button listen to a signal from the shortcut and let it open the menu or
- let the deco export the position via a (dynamic) Qt (or even X11) property (probably the best solution?!)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11734
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 21, 2012, 2:50 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/scripting/workspace_wrapper.h 0b44b6e
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-03-27 08:20:31 UTC
Permalink
Post by Bellegarde Cédric
kwin/client.h, lines 594-596
<http://git.reviewboard.kde.org/r/104344/diff/5/?file=54066#file54066line594>
why is this needed? We don't have something like that for the normal menu.
We need to this to get button position when calling menu via shortcut. Window menu always popup on left side...
We can disable this code if you thinks it's not needed.
The better approach was to let the deco suggest the popup position, yesno?
I mean, the menu could just be in the center or on the bottom or where not else.
Window Menu simply ignore button position and always popup on left, i can't follow this behaviour....
We're about to break deco ABI anyway.
However, other methods would be to
- have the button listen to a signal from the shortcut and let it open the menu or
- let the deco export the position via a (dynamic) Qt (or even X11) property (probably the best solution?!)
Please read: "i can follow this behaviour...." :)

For the decoration exporting a property, i really don't know how to do this, can't find a way to access the good kcommondecoration object from core...

So, i'm going to fallback to "window menu" behaviour...


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11734
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 21, 2012, 2:50 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/scripting/workspace_wrapper.h 0b44b6e
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-03-27 10:01:05 UTC
Permalink
Post by Bellegarde Cédric
kwin/client.h, lines 594-596
<http://git.reviewboard.kde.org/r/104344/diff/5/?file=54066#file54066line594>
why is this needed? We don't have something like that for the normal menu.
We need to this to get button position when calling menu via shortcut. Window menu always popup on left side...
We can disable this code if you thinks it's not needed.
The better approach was to let the deco suggest the popup position, yesno?
I mean, the menu could just be in the center or on the bottom or where not else.
Window Menu simply ignore button position and always popup on left, i can't follow this behaviour....
We're about to break deco ABI anyway.
However, other methods would be to
- have the button listen to a signal from the shortcut and let it open the menu or
- let the deco export the position via a (dynamic) Qt (or even X11) property (probably the best solution?!)
Please read: "i can follow this behaviour...." :)
For the decoration exporting a property, i really don't know how to do this, can't find a way to access the good kcommondecoration object from core...
So, i'm going to fallback to "window menu" behaviour...
Ok, i remember why i use applicationMenuIsLeft()...

It's already like this in kcommondecoration...
Post by Bellegarde Cédric
I mean, the menu could just be in the center or on the bottom or where not else.
No, in kcommondecoration, buttons are left or right placed in titlebar:
bool KCommonDecorationButton::isLeft();

With this method, overlay menubar is left/right placed on titlebar...


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11734
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 21, 2012, 2:50 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/scripting/workspace_wrapper.h 0b44b6e
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Thomas Lübking
2012-03-27 14:08:39 UTC
Permalink
Post by Bellegarde Cédric
kwin/client.h, lines 594-596
<http://git.reviewboard.kde.org/r/104344/diff/5/?file=54066#file54066line594>
why is this needed? We don't have something like that for the normal menu.
We need to this to get button position when calling menu via shortcut. Window menu always popup on left side...
We can disable this code if you thinks it's not needed.
The better approach was to let the deco suggest the popup position, yesno?
I mean, the menu could just be in the center or on the bottom or where not else.
Window Menu simply ignore button position and always popup on left, i can't follow this behaviour....
We're about to break deco ABI anyway.
However, other methods would be to
- have the button listen to a signal from the shortcut and let it open the menu or
- let the deco export the position via a (dynamic) Qt (or even X11) property (probably the best solution?!)
Please read: "i can follow this behaviour...." :)
For the decoration exporting a property, i really don't know how to do this, can't find a way to access the good kcommondecoration object from core...
So, i'm going to fallback to "window menu" behaviour...
Ok, i remember why i use applicationMenuIsLeft()...
It's already like this in kcommondecoration...
I mean, the menu could just be in the center or on the bottom or where not else.
bool KCommonDecorationButton::isLeft();
With this method, overlay menubar is left/right placed on titlebar...
a) KCommonDecoration is NOT the official API, but KDecoration is - Hugo has afair stated to preferably avoid that artificial limitations in future versions and if you make this a KCommonDecoration specific thing, you might watch it being dropped during the next year, because that wrapper class is really a kludge

b) the KCommonDecorationButton::isLeft() indirectly relies on the button config string, which may and has been happily ignored by decorations (because they relied on asymmetric button pixmaps) - i'd better be prepared for such approaches in relation with the aurorae engine.

c) Both, KDecoration and the created decoration widget() are QObjects, so QObject::setProperty( const char *name, const QVariant & value ) allows you to store random stuff on them at runtime.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11734
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 27, 2012, 2 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt c766fdf
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h c35643f
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 8893fa4
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp 717a82d
kwin/scripting/workspace_wrapper.h c4ea8f6
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp 120481b
kwin/workspace.h 1c6a831
kwin/workspace.cpp 5542a3d
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Hugo Pereira Da Costa
2012-03-23 09:18:33 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11777
-----------------------------------------------------------


Couple of comments on the oxygen code bellow.

Now for the testing part, I have noticed a couple of issues
1/ menu placement: see Loading Image...
2/ you can select "Menu Popup" or "Overlay" in the advanced settings, and the application menu dissappear, even if you use a decoration that does not support the application menu button, or don't have the button in the decoration. You end up with no menus, with no clue about what you are missing. I think the menu should not be hidden unless the two conditions above are fullfilled (proper decoration and proper buttons settings).
When I switch decorations, with the feature enabled from oxygen to "anything" that does not support, or when I change buttons layout, menus should "reappear".
3/ I'm no big fan of the overlay menubar being plasma. You now get possibly three different style: the decoration, a plasma overlay, and (when pressing) a QStyle menus ... Looks quite a patchwork. I think I would have preferred a standard "QStyle" menu, possibly with some opacity.



kwin/clients/oxygen/oxygenbutton.h
<http://git.reviewboard.kde.org/r/104344/#comment9337>

No "all uppercase" enums (that does not follow coding style)

Should be "AppMenuButton_TileSize"
(that's consistent with the metrics enumerations in Oxygen::style)



kwin/clients/oxygen/oxygenbutton.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9342>

oxygen does not use "slot" as a prefix to mark slots. Maybe rename "updateAppMenuButton"

(or anything you find more appropriate)



kwin/clients/oxygen/oxygenbutton.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9338>

Need to adjust the comments above, since this is not what the code does anymore

// translate buttons appropriately if window is maximized



kwin/clients/oxygen/oxygenbutton.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9340>

please keep the white line
(just for consistency with the rest of the code)
(I know my 'own' coding convention are not "perfect", nor systematic, nor documented, but still :))



kwin/clients/oxygen/oxygenbutton.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9341>

please keep the white line



kwin/kcmkwin/kwindecoration/buttons.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9339>

dbusmenu is jargon. No user will know what it is. Maybe just "Button showing application menu"



- Hugo Pereira Da Costa
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 21, 2012, 2:50 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/scripting/workspace_wrapper.h 0b44b6e
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Hugo Pereira Da Costa
2012-03-23 09:23:26 UTC
Permalink
Post by Bellegarde Cédric
Post by Hugo Pereira Da Costa
Couple of comments on the oxygen code bellow.
Now for the testing part, I have noticed a couple of issues
1/ menu placement: see http://wstaw.org/m/2012/03/23/plasma-desktopuF3410.png
2/ you can select "Menu Popup" or "Overlay" in the advanced settings, and the application menu dissappear, even if you use a decoration that does not support the application menu button, or don't have the button in the decoration. You end up with no menus, with no clue about what you are missing. I think the menu should not be hidden unless the two conditions above are fullfilled (proper decoration and proper buttons settings).
When I switch decorations, with the feature enabled from oxygen to "anything" that does not support, or when I change buttons layout, menus should "reappear".
3/ I'm no big fan of the overlay menubar being plasma. You now get possibly three different style: the decoration, a plasma overlay, and (when pressing) a QStyle menus ... Looks quite a patchwork. I think I would have preferred a standard "QStyle" menu, possibly with some opacity.
... meant: "a standard "qstyle menubar"


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11777
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 21, 2012, 2:50 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/scripting/workspace_wrapper.h 0b44b6e
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-03-23 09:24:35 UTC
Permalink
Post by Hugo Pereira Da Costa
Post by Hugo Pereira Da Costa
Couple of comments on the oxygen code bellow.
Now for the testing part, I have noticed a couple of issues
1/ menu placement: see http://wstaw.org/m/2012/03/23/plasma-desktopuF3410.png
2/ you can select "Menu Popup" or "Overlay" in the advanced settings, and the application menu dissappear, even if you use a decoration that does not support the application menu button, or don't have the button in the decoration. You end up with no menus, with no clue about what you are missing. I think the menu should not be hidden unless the two conditions above are fullfilled (proper decoration and proper buttons settings).
When I switch decorations, with the feature enabled from oxygen to "anything" that does not support, or when I change buttons layout, menus should "reappear".
3/ I'm no big fan of the overlay menubar being plasma. You now get possibly three different style: the decoration, a plasma overlay, and (when pressing) a QStyle menus ... Looks quite a patchwork. I think I would have preferred a standard "QStyle" menu, possibly with some opacity.
... meant: "a standard "qstyle menubar"
2/ It's normal, you can use the application menu with no button in decoration, just with a global shortcut.


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11777
-----------------------------------------------------------
Post by Hugo Pereira Da Costa
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 21, 2012, 2:50 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/scripting/workspace_wrapper.h 0b44b6e
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Hugo Pereira Da Costa
2012-03-23 09:26:14 UTC
Permalink
Post by Hugo Pereira Da Costa
Post by Hugo Pereira Da Costa
Couple of comments on the oxygen code bellow.
Now for the testing part, I have noticed a couple of issues
1/ menu placement: see http://wstaw.org/m/2012/03/23/plasma-desktopuF3410.png
2/ you can select "Menu Popup" or "Overlay" in the advanced settings, and the application menu dissappear, even if you use a decoration that does not support the application menu button, or don't have the button in the decoration. You end up with no menus, with no clue about what you are missing. I think the menu should not be hidden unless the two conditions above are fullfilled (proper decoration and proper buttons settings).
When I switch decorations, with the feature enabled from oxygen to "anything" that does not support, or when I change buttons layout, menus should "reappear".
3/ I'm no big fan of the overlay menubar being plasma. You now get possibly three different style: the decoration, a plasma overlay, and (when pressing) a QStyle menus ... Looks quite a patchwork. I think I would have preferred a standard "QStyle" menu, possibly with some opacity.
... meant: "a standard "qstyle menubar"
2/ It's normal, you can use the application menu with no button in decoration, just with a global shortcut.
One more
4/ when I changed back the setting to "in application menu", the menubar reappears in applications, but the button remains in the decoration for all existing clients (and does nothing). It should disappear. (the button is already not visible for newly started windows)


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11777
-----------------------------------------------------------
Post by Hugo Pereira Da Costa
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 21, 2012, 2:50 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/scripting/workspace_wrapper.h 0b44b6e
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Hugo Pereira Da Costa
2012-03-23 09:33:08 UTC
Permalink
Post by Hugo Pereira Da Costa
Post by Hugo Pereira Da Costa
Couple of comments on the oxygen code bellow.
Now for the testing part, I have noticed a couple of issues
1/ menu placement: see http://wstaw.org/m/2012/03/23/plasma-desktopuF3410.png
2/ you can select "Menu Popup" or "Overlay" in the advanced settings, and the application menu dissappear, even if you use a decoration that does not support the application menu button, or don't have the button in the decoration. You end up with no menus, with no clue about what you are missing. I think the menu should not be hidden unless the two conditions above are fullfilled (proper decoration and proper buttons settings).
When I switch decorations, with the feature enabled from oxygen to "anything" that does not support, or when I change buttons layout, menus should "reappear".
3/ I'm no big fan of the overlay menubar being plasma. You now get possibly three different style: the decoration, a plasma overlay, and (when pressing) a QStyle menus ... Looks quite a patchwork. I think I would have preferred a standard "QStyle" menu, possibly with some opacity.
... meant: "a standard "qstyle menubar"
2/ It's normal, you can use the application menu with no button in decoration, just with a global shortcut.
One more
4/ when I changed back the setting to "in application menu", the menubar reappears in applications, but the button remains in the decoration for all existing clients (and does nothing). It should disappear. (the button is already not visible for newly started windows)
@Cedric,
and what if the shortcut is not set ?
in general, the usability of the feature is quite complex: you have to go to three quite different and scattered places to make it work
(global shortcut, window decorations, and this "advanced tab"). Maybe add the possibility to configure the global shortcut also in the advance tab, next to the selection box ?
(similar to the global shortcut to enable/disable desktop effects in the "desktop effects" settings ?)


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11777
-----------------------------------------------------------
Post by Hugo Pereira Da Costa
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 21, 2012, 2:50 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/scripting/workspace_wrapper.h 0b44b6e
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-03-23 09:52:10 UTC
Permalink
Post by Hugo Pereira Da Costa
Post by Hugo Pereira Da Costa
Couple of comments on the oxygen code bellow.
Now for the testing part, I have noticed a couple of issues
1/ menu placement: see http://wstaw.org/m/2012/03/23/plasma-desktopuF3410.png
2/ you can select "Menu Popup" or "Overlay" in the advanced settings, and the application menu dissappear, even if you use a decoration that does not support the application menu button, or don't have the button in the decoration. You end up with no menus, with no clue about what you are missing. I think the menu should not be hidden unless the two conditions above are fullfilled (proper decoration and proper buttons settings).
When I switch decorations, with the feature enabled from oxygen to "anything" that does not support, or when I change buttons layout, menus should "reappear".
3/ I'm no big fan of the overlay menubar being plasma. You now get possibly three different style: the decoration, a plasma overlay, and (when pressing) a QStyle menus ... Looks quite a patchwork. I think I would have preferred a standard "QStyle" menu, possibly with some opacity.
... meant: "a standard "qstyle menubar"
2/ It's normal, you can use the application menu with no button in decoration, just with a global shortcut.
One more
4/ when I changed back the setting to "in application menu", the menubar reappears in applications, but the button remains in the decoration for all existing clients (and does nothing). It should disappear. (the button is already not visible for newly started windows)
@Cedric,
and what if the shortcut is not set ?
in general, the usability of the feature is quite complex: you have to go to three quite different and scattered places to make it work
(global shortcut, window decorations, and this "advanced tab"). Maybe add the possibility to configure the global shortcut also in the advance tab, next to the selection box ?
(similar to the global shortcut to enable/disable desktop effects in the "desktop effects" settings ?)
Ok, good idea ;)

Global shortcuts avantage is that you can use the feature even if decorator do not know how to draw an application button.


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11777
-----------------------------------------------------------
Post by Hugo Pereira Da Costa
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 21, 2012, 2:50 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/scripting/workspace_wrapper.h 0b44b6e
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-03-26 13:52:30 UTC
Permalink
Post by Hugo Pereira Da Costa
Post by Hugo Pereira Da Costa
Couple of comments on the oxygen code bellow.
Now for the testing part, I have noticed a couple of issues
1/ menu placement: see http://wstaw.org/m/2012/03/23/plasma-desktopuF3410.png
2/ you can select "Menu Popup" or "Overlay" in the advanced settings, and the application menu dissappear, even if you use a decoration that does not support the application menu button, or don't have the button in the decoration. You end up with no menus, with no clue about what you are missing. I think the menu should not be hidden unless the two conditions above are fullfilled (proper decoration and proper buttons settings).
When I switch decorations, with the feature enabled from oxygen to "anything" that does not support, or when I change buttons layout, menus should "reappear".
3/ I'm no big fan of the overlay menubar being plasma. You now get possibly three different style: the decoration, a plasma overlay, and (when pressing) a QStyle menus ... Looks quite a patchwork. I think I would have preferred a standard "QStyle" menu, possibly with some opacity.
... meant: "a standard "qstyle menubar"
2/ It's normal, you can use the application menu with no button in decoration, just with a global shortcut.
One more
4/ when I changed back the setting to "in application menu", the menubar reappears in applications, but the button remains in the decoration for all existing clients (and does nothing). It should disappear. (the button is already not visible for newly started windows)
@Cedric,
and what if the shortcut is not set ?
in general, the usability of the feature is quite complex: you have to go to three quite different and scattered places to make it work
(global shortcut, window decorations, and this "advanced tab"). Maybe add the possibility to configure the global shortcut also in the advance tab, next to the selection box ?
(similar to the global shortcut to enable/disable desktop effects in the "desktop effects" settings ?)
Ok, good idea ;)
Global shortcuts avantage is that you can use the feature even if decorator do not know how to draw an application button.
I'm no big fan of the overlay menubar being plasma. You now get possibly three different style: the decoration, a plasma overlay,
and (when pressing) a QStyle menus ... Looks quite a patchwork. I think I would have preferred a standard "QStyle" menu, possibly
with some opacity.
After some testing, using a QMenuBar do not look that good:
- it really miss contrast with the application, i think
- having a widget similar to titlebar looks bad when overlaping with titlebar objects
- it have many issues i'm not sure i will have time to fix them...

Question: Do we drop Horizontal menu support ? Do we keep plasma one ?


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11777
-----------------------------------------------------------
Post by Hugo Pereira Da Costa
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 21, 2012, 2:50 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/scripting/workspace_wrapper.h 0b44b6e
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Hugo Pereira Da Costa
2012-03-26 14:12:52 UTC
Permalink
Post by Hugo Pereira Da Costa
Post by Hugo Pereira Da Costa
Couple of comments on the oxygen code bellow.
Now for the testing part, I have noticed a couple of issues
1/ menu placement: see http://wstaw.org/m/2012/03/23/plasma-desktopuF3410.png
2/ you can select "Menu Popup" or "Overlay" in the advanced settings, and the application menu dissappear, even if you use a decoration that does not support the application menu button, or don't have the button in the decoration. You end up with no menus, with no clue about what you are missing. I think the menu should not be hidden unless the two conditions above are fullfilled (proper decoration and proper buttons settings).
When I switch decorations, with the feature enabled from oxygen to "anything" that does not support, or when I change buttons layout, menus should "reappear".
3/ I'm no big fan of the overlay menubar being plasma. You now get possibly three different style: the decoration, a plasma overlay, and (when pressing) a QStyle menus ... Looks quite a patchwork. I think I would have preferred a standard "QStyle" menu, possibly with some opacity.
... meant: "a standard "qstyle menubar"
2/ It's normal, you can use the application menu with no button in decoration, just with a global shortcut.
One more
4/ when I changed back the setting to "in application menu", the menubar reappears in applications, but the button remains in the decoration for all existing clients (and does nothing). It should disappear. (the button is already not visible for newly started windows)
@Cedric,
and what if the shortcut is not set ?
in general, the usability of the feature is quite complex: you have to go to three quite different and scattered places to make it work
(global shortcut, window decorations, and this "advanced tab"). Maybe add the possibility to configure the global shortcut also in the advance tab, next to the selection box ?
(similar to the global shortcut to enable/disable desktop effects in the "desktop effects" settings ?)
Ok, good idea ;)
Global shortcuts avantage is that you can use the feature even if decorator do not know how to draw an application button.
Post by Hugo Pereira Da Costa
I'm no big fan of the overlay menubar being plasma. You now get possibly three different style: the decoration, a plasma overlay,
and (when pressing) a QStyle menus ... Looks quite a patchwork. I think I would have preferred a standard "QStyle" menu, possibly
with some opacity.
- it really miss contrast with the application, i think
- having a widget similar to titlebar looks bad when overlaping with titlebar objects
- it have many issues i'm not sure i will have time to fix them...
Question: Do we drop Horizontal menu support ? Do we keep plasma one ?
nono.
I'd just forget about my suggestion, for the time being ;)
I guess one "could" tweak the style to make the floating menubar appear like "Menus", that is:
- be horizontal
- but have a rounded frame, and a shadow.
But that's out of the scope of this review request.


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11777
-----------------------------------------------------------
Post by Hugo Pereira Da Costa
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 21, 2012, 2:50 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/scripting/workspace_wrapper.h 0b44b6e
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Hugo Pereira Da Costa
2012-03-23 09:19:05 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11778
-----------------------------------------------------------


- Hugo Pereira Da Costa
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 21, 2012, 2:50 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h b394687
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp f26699a
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h c0ab6b2
kwin/options.cpp f17a421
kwin/scripting/workspace_wrapper.h 0b44b6e
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp dfb6fd4
kwin/workspace.h 1c6a831
kwin/workspace.cpp 66fb50c
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-03-27 14:00:15 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated March 27, 2012, 2 p.m.)


Review request for kwin.


Changes
-------

- Fix a bug with menubar placement and right placed button
- Add shortcut configuration in kcm
- Use standard oxygen button
- Remove button when disabling option
- fix code issues


Description
-------

Here a patch to add appmenu support to kwin:
- via a menu button in titlebar
- via a global shortcut

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

Kubuntu and ArchLinux packages (KDE 4.8.1 backport) availables here:
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583

It looks like this:
http://youtu.be/j0o1sRLRc60

I remove ( http://kde-look.org/CONTENT/content-pre1/141254-1.png ) this way to show menu button because:
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad


Diffs (updated)
-----

CMakeLists.txt c766fdf
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h c35643f
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 8893fa4
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp 717a82d
kwin/scripting/workspace_wrapper.h c4ea8f6
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp 120481b
kwin/workspace.h 1c6a831
kwin/workspace.cpp 5542a3d

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Bellegarde Cédric
2012-03-27 14:03:28 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11908
-----------------------------------------------------------

Ship it!


Diff r6 also add:
- Kded module with renamed importer class
- KDE_BUILD_KAPPMENU build option

- Bellegarde Cédric
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 27, 2012, 2 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt c766fdf
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h c35643f
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 8893fa4
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp 717a82d
kwin/scripting/workspace_wrapper.h c4ea8f6
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp 120481b
kwin/workspace.h 1c6a831
kwin/workspace.cpp 5542a3d
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Thomas Lübking
2012-03-27 17:22:41 UTC
Permalink
Post by Bellegarde Cédric
Post by Bellegarde Cédric
- Kded module with renamed importer class
- KDE_BUILD_KAPPMENU build option
did you give a ship it to yourself?
i doubt that's the point about review requests...


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11908
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 27, 2012, 2 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt c766fdf
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h c35643f
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 8893fa4
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp 717a82d
kwin/scripting/workspace_wrapper.h c4ea8f6
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp 120481b
kwin/workspace.h 1c6a831
kwin/workspace.cpp 5542a3d
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Martin Gräßlin
2012-03-27 17:28:50 UTC
Permalink
Post by Thomas Lübking
Post by Bellegarde Cédric
- Kded module with renamed importer class
- KDE_BUILD_KAPPMENU build option
did you give a ship it to yourself?
i doubt that's the point about review requests...
concerning ship its... here we need two, one from KWin and one from Oxygen.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11908
-----------------------------------------------------------
Post by Thomas Lübking
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 27, 2012, 2 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt c766fdf
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h c35643f
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 8893fa4
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp 717a82d
kwin/scripting/workspace_wrapper.h c4ea8f6
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp 120481b
kwin/workspace.h 1c6a831
kwin/workspace.cpp 5542a3d
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-03-27 17:58:55 UTC
Permalink
Post by Thomas Lübking
Post by Bellegarde Cédric
- Kded module with renamed importer class
- KDE_BUILD_KAPPMENU build option
did you give a ship it to yourself?
i doubt that's the point about review requests...
concerning ship its... here we need two, one from KWin and one from Oxygen.
No i wanted to add a comment to diff6... And i just understanded what "Ship it" mean...


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11908
-----------------------------------------------------------
Post by Thomas Lübking
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated March 27, 2012, 2 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt c766fdf
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 463692d
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h c35643f
kwin/client.cpp 8ff98c6
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 8893fa4
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 02a33e9
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp 717a82d
kwin/scripting/workspace_wrapper.h c4ea8f6
kwin/scripting/workspace_wrapper.cpp c0de078
kwin/useractions.cpp 120481b
kwin/workspace.h 1c6a831
kwin/workspace.cpp 5542a3d
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-04-03 12:37:27 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated April 3, 2012, 12:37 p.m.)


Review request for kwin.


Changes
-------

Use button position for menu placement


Description
-------

Here a patch to add appmenu support to kwin:
- via a menu button in titlebar
- via a global shortcut

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

Kubuntu and ArchLinux packages (KDE 4.8.1 backport) availables here:
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583

It looks like this:
http://youtu.be/j0o1sRLRc60

I remove ( http://kde-look.org/CONTENT/content-pre1/141254-1.png ) this way to show menu button because:
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad


Diffs (updated)
-----

CMakeLists.txt c766fdf
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt c2b7cb7
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 81eb3e9
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h d275221
kwin/scripting/workspace_wrapper.cpp 35ef346
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Bellegarde Cédric
2012-04-05 11:29:35 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated April 5, 2012, 11:29 a.m.)


Review request for kwin.


Changes
-------

Reupload patch, revision 7 was an old version...

- Use button position


Description
-------

Here a patch to add appmenu support to kwin:
- via a menu button in titlebar
- via a global shortcut

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

Kubuntu and ArchLinux packages (KDE 4.8.1 backport) availables here:
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583

It looks like this:
http://youtu.be/j0o1sRLRc60

I remove ( http://kde-look.org/CONTENT/content-pre1/141254-1.png ) this way to show menu button because:
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad


Diffs (updated)
-----

CMakeLists.txt c766fdf
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt c2b7cb7
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 81eb3e9
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h d275221
kwin/scripting/workspace_wrapper.cpp 35ef346
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Giorgos Tsiapaliwkas
2012-04-07 14:45:28 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review12240
-----------------------------------------------------------


Btw the src/module/* files are under canonical's license stuff.
Is that ok?

- Giorgos Tsiapaliwkas
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 5, 2012, 11:29 a.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt c766fdf
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt c2b7cb7
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 81eb3e9
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h d275221
kwin/scripting/workspace_wrapper.cpp 35ef346
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Giorgos Tsiapaliwkas
2012-04-07 14:45:35 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review12241
-----------------------------------------------------------


Btw the src/module/* files are under canonical's license stuff.
Is that ok?

- Giorgos Tsiapaliwkas
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 5, 2012, 11:29 a.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt c766fdf
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt c2b7cb7
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 81eb3e9
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h d275221
kwin/scripting/workspace_wrapper.cpp 35ef346
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-04-09 21:47:12 UTC
Permalink
Post by Bellegarde Cédric
Post by Giorgos Tsiapaliwkas
Btw the src/module/* files are under canonical's license stuff.
Is that ok?
This is GPL code, why should this be a problem ?

But headers are bad, will have to fix them... Lionel, can you do this ?


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review12241
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 5, 2012, 11:29 a.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt c766fdf
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt c2b7cb7
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp 81eb3e9
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h d275221
kwin/scripting/workspace_wrapper.cpp 35ef346
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-04-16 13:55:05 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated April 16, 2012, 1:55 p.m.)


Review request for kwin.


Changes
-------

Update kded module GPL headers.


Description
-------

Here a patch to add appmenu support to kwin:
- via a menu button in titlebar
- via a global shortcut

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

Kubuntu and ArchLinux packages (KDE 4.8.1 backport) availables here:
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583

It looks like this:
http://youtu.be/j0o1sRLRc60

I remove ( http://kde-look.org/CONTENT/content-pre1/141254-1.png ) this way to show menu button because:
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad


Diffs (updated)
-----

CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Martin Gräßlin
2012-04-20 20:43:15 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review12734
-----------------------------------------------------------



kwin/CMakeLists.txt
<http://git.reviewboard.kde.org/r/104344/#comment9946>

menubar.cpp is probably also only needed if KWIN_BUILD_KAPPMENU is true. So best wrap it in an iff block like done for e.g. scripting.



kwin/bridge.h
<http://git.reviewboard.kde.org/r/104344/#comment9948>

I would suggest to have the API always including the two methods even if the define is not set.



kwin/bridge.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9949>

this should then become:
bool Bridge::hasApplicationMenu() const
{
#ifdef KWIN_BUILD_KAPPMENU
return Workspace::self()->hasApplicationMenu(c->window());
#else
return false;
#endif
}



kwin/bridge.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9950>

and here also the ifdef inside the method.

instead of using c->workspace() you can just use the singleton accessor:
Workspace::self()



kwin/clients/oxygen/oxygenbutton.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9967>

*cough* :-)



kwin/kcmkwin/kwindecoration/preview.h
<http://git.reviewboard.kde.org/r/104344/#comment9968>

same as in bridge.h



kwin/libkdecorations/kcommondecoration.h
<http://git.reviewboard.kde.org/r/104344/#comment9969>

In the library I think we should not have the ifdefs. That might cause ABI issues.

Actually the library does not use anything of appmenu, so all can be handled inside the bridge.



kwin/libkdecorations/kcommondecoration.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9970>

whitespaces and coding style



kwin/menubar.h
<http://git.reviewboard.kde.org/r/104344/#comment9971>

that does not sound very Qt: getters do not start with get :-)

If it is really a window ID please use type WId.



kwin/menubar.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9951>

is it intended that you don't pass a parent to the QGraphicsView?



kwin/menubar.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9952>

?



kwin/options.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9953>

I think here in the options we don't need all the ifdefs. Look above what has been done for the decorations. I think that would work here as well:

#ifdef KWIN_BUILD_KAPPMENU
m_applicationMenuType = applicationMenu(config.readEntry("ApplicationMenu", "ApplicationMenuNone"));
#else
m_applicationMenuType = ApplicationMenuNone;
#endif

That way we only need one ifdef and can have the header not adjusted at all :-)



kwin/workspace.h
<http://git.reviewboard.kde.org/r/104344/#comment9954>

you don't need to include config-kwin.h here. It gets include later on by the include of utils.h



kwin/workspace.h
<http://git.reviewboard.kde.org/r/104344/#comment9955>

is the wid really a window id? In that case you should use a WId type or at least qulonglong.

Also here it might be as well a good idea to have the ifdef only in the implementation



kwin/workspace.h
<http://git.reviewboard.kde.org/r/104344/#comment9956>

can we have m_variableName for new things?

Yes I know it's inconsistant but we should try to be consistant for new things



kwin/workspace.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9957>

please use NULL instead of 0.

When we are using C++11 I plan to do a global replace of NULL to nullptr which only works if it used to be NULL.



kwin/workspace.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9958>

if (!applicationMenuImporter)



kwin/workspace.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9959>

if (!menubar)



kwin/workspace.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9960>

if (!applicationMenuImporter && options...)



kwin/workspace.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9962>

the second part of this else if (null check) is not needed. It is save to delete a null pointer.

Also please use NULL when setting applicationMenuImporter to NULL.



kwin/workspace.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9963>

return !applicationMenuImporter && applicationMenuImporter->menuForWinId(wid);



kwin/workspace.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9964>

why is this needed at all? options is available to everything of KWin, so no need to wrap it in workspace



kwin/workspace.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9965>

if (!menubar && ...)



kwin/workspace.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9966>

somehow I don't like this. Why not emitting a signal in workspace and have in client a connect from signal to signal.

That way you can also get rid of the emitAppMenu*() methods which wrap the emit call


- Martin GrÀßlin
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 16, 2012, 1:55 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Lionel Chauvin
2012-04-25 17:51:45 UTC
Permalink
Post by Bellegarde Cédric
kwin/workspace.cpp, line 541
<http://git.reviewboard.kde.org/r/104344/diff/9/?file=56774#file56774line541>
if (!applicationMenuImporter)
do you mean:
if (applicationMenuImporter)
?
Post by Bellegarde Cédric
kwin/workspace.cpp, line 543
<http://git.reviewboard.kde.org/r/104344/diff/9/?file=56774#file56774line543>
if (!menubar)
do you mean:
if (menubar)
?
Post by Bellegarde Cédric
kwin/workspace.cpp, line 2112
<http://git.reviewboard.kde.org/r/104344/diff/9/?file=56774#file56774line2112>
if (!menubar && ...)
do you mean:
if (menubar && ...)
?
Post by Bellegarde Cédric
kwin/libkdecorations/kcommondecoration.cpp, lines 544-548
<http://git.reviewboard.kde.org/r/104344/diff/9/?file=56762#file56762line544>
whitespaces and coding style
Any idea about how improve the coding style in this case ?


- Lionel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review12734
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 16, 2012, 1:55 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Thomas Lübking
2012-04-25 18:16:42 UTC
Permalink
Post by Lionel Chauvin
kwin/workspace.cpp, line 541
<http://git.reviewboard.kde.org/r/104344/diff/9/?file=56774#file56774line541>
if (!applicationMenuImporter)
if (applicationMenuImporter)
?
"likely" ;-)
core concern should be coding style - do not explicitly compare a pointer to check its validity and especially do not compare it to an integer (but "NULL", if you really must)

In this particular case you can however omit the entire check because it's legal to delete a null pointer, ie. "void *prt = NULL; delete ptr;" is just fine.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review12734
-----------------------------------------------------------
Post by Lionel Chauvin
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 16, 2012, 1:55 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Martin Gräßlin
2012-04-25 18:17:16 UTC
Permalink
Post by Lionel Chauvin
kwin/workspace.cpp, line 2112
<http://git.reviewboard.kde.org/r/104344/diff/9/?file=56774#file56774line2112>
if (!menubar && ...)
if (menubar && ...)
?
yes for all three I mean if (var).

You see how much it confused me, I read each in the most wrong way :-)
Post by Lionel Chauvin
kwin/libkdecorations/kcommondecoration.cpp, lines 544-548
<http://git.reviewboard.kde.org/r/104344/diff/9/?file=56762#file56762line544>
whitespaces and coding style
Any idea about how improve the coding style in this case ?
sure, remove the ifdef - not needed in the lib. wrapper->hasApplicationMenu() returns false in case KWin core is built without appmenu support.

but even without that the else belongs on the same line as the }
if (foo) {
} else {
}


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review12734
-----------------------------------------------------------
Post by Lionel Chauvin
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 16, 2012, 1:55 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Martin Gräßlin
2012-04-20 20:44:15 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review12736
-----------------------------------------------------------


I cannot give you a review on the kded module. I think that one should get a traditional review announced on kde-core-devel mailinglist.

- Martin GrÀßlin
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 16, 2012, 1:55 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Thomas Lübking
2012-04-21 10:48:09 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review12754
-----------------------------------------------------------



kwin/workspace.cpp
<http://git.reviewboard.kde.org/r/104344/#comment9973>

In addition: this looks like it performs a synchronous dbus call, is that correct?


- Thomas LÃŒbking
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 16, 2012, 1:55 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Hugo Pereira Da Costa
2012-04-27 14:24:05 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review12984
-----------------------------------------------------------


Did I mention that its ok from the oxygen side ?
If not: it is ok from the oxygen side.
(to be honest I'm not 100% happy with the menu button appearance, but it is good enough for release, could be tweaked later on, and also I'd like to have Nuno's feedback).
Voila !

- Hugo Pereira Da Costa
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 16, 2012, 1:55 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Martin Gräßlin
2012-04-27 14:44:58 UTC
Permalink
Post by Bellegarde Cédric
Post by Hugo Pereira Da Costa
Did I mention that its ok from the oxygen side ?
If not: it is ok from the oxygen side.
(to be honest I'm not 100% happy with the menu button appearance, but it is good enough for release, could be tweaked later on, and also I'd like to have Nuno's feedback).
Voila !
Also artwork freeze is much later, so much more time to get Nuno love :-)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review12984
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 16, 2012, 1:55 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Lamarque Vieira Souza
2012-04-27 19:01:58 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review13002
-----------------------------------------------------------



appmenu/lib/com.canonical.AppMenu.Registrar.xml
<http://git.reviewboard.kde.org/r/104344/#comment10118>

Curious that Canonical is using a Spanish (also Portuguese word) for this :-)



appmenu/lib/importer_interface.h
<http://git.reviewboard.kde.org/r/104344/#comment10117>

QDBusReply and waitForFinished are no go from my part. Please use them only when really really necessary.


- Lamarque Vieira Souza
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 16, 2012, 1:55 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-07-22 18:08:17 UTC
Permalink
Post by Bellegarde Cédric
appmenu/lib/com.canonical.AppMenu.Registrar.xml, line 7
<http://git.reviewboard.kde.org/r/104344/diff/9/?file=56727#file56727line7>
Curious that Canonical is using a Spanish (also Portuguese word) for this :-)
Registrar is an english word ;)
Post by Bellegarde Cédric
appmenu/lib/importer_interface.h, line 46
<http://git.reviewboard.kde.org/r/104344/diff/9/?file=56728#file56728line46>
QDBusReply and waitForFinished are no go from my part. Please use them only when really really necessary.
I thinks it's needed but i'm rewriting all the code to bypass canonical copyright (and make it more flexible)...

By the way, in krunner-appmenu, i can see reply.waitForFinished(), will talk with A.Fiestas about this issue.


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review13002
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 16, 2012, 1:55 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Thomas Lübking
2012-07-22 18:17:29 UTC
Permalink
Post by Bellegarde Cédric
appmenu/lib/importer_interface.h, line 46
<http://git.reviewboard.kde.org/r/104344/diff/9/?file=56728#file56728line46>
QDBusReply and waitForFinished are no go from my part. Please use them only when really really necessary.
I thinks it's needed but i'm rewriting all the code to bypass canonical copyright (and make it more flexible)...
By the way, in krunner-appmenu, i can see reply.waitForFinished(), will talk with A.Fiestas about this issue.
krunner is not the compositor - if it blocks for n seconds, that's a minor and local issue - if kwin blocks for n seconds, that's a major issue.
Therefore blocking dbus calls (where the other side may hang) are no option here.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review13002
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 16, 2012, 1:55 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Martin Gräßlin
2012-07-22 20:00:59 UTC
Permalink
Post by Bellegarde Cédric
appmenu/lib/importer_interface.h, line 46
<http://git.reviewboard.kde.org/r/104344/diff/9/?file=56728#file56728line46>
QDBusReply and waitForFinished are no go from my part. Please use them only when really really necessary.
I thinks it's needed but i'm rewriting all the code to bypass canonical copyright (and make it more flexible)...
By the way, in krunner-appmenu, i can see reply.waitForFinished(), will talk with A.Fiestas about this issue.
krunner is not the compositor - if it blocks for n seconds, that's a minor and local issue - if kwin blocks for n seconds, that's a major issue.
Therefore blocking dbus calls (where the other side may hang) are no option here.
krunner is also a highly threaded application. So if it's inside a runner, it's just the runner which is blocked. Nevertheless I would love to see only non-blocking D-Bus calls in KDE codebase :-)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review13002
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 16, 2012, 1:55 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-07-26 21:06:14 UTC
Permalink
Post by Bellegarde Cédric
appmenu/lib/importer_interface.h, line 46
<http://git.reviewboard.kde.org/r/104344/diff/9/?file=56728#file56728line46>
QDBusReply and waitForFinished are no go from my part. Please use them only when really really necessary.
I thinks it's needed but i'm rewriting all the code to bypass canonical copyright (and make it more flexible)...
By the way, in krunner-appmenu, i can see reply.waitForFinished(), will talk with A.Fiestas about this issue.
krunner is not the compositor - if it blocks for n seconds, that's a minor and local issue - if kwin blocks for n seconds, that's a major issue.
Therefore blocking dbus calls (where the other side may hang) are no option here.
krunner is also a highly threaded application. So if it's inside a runner, it's just the runner which is blocked. Nevertheless I would love to see only non-blocking D-Bus calls in KDE codebase :-)
I'm sure dbusmenu will not work without a blocking dbus call... (but i may be wrong)...

I'm thinking about another solution, move menu drawing code to kded:
- Kwin tell kded-appmenu: "Show menu/menubar at position
- Kded popup menu and dbus blocking call should not be a problem

What about this solution ?


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review13002
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 16, 2012, 1:55 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Lamarque Vieira Souza
2012-07-28 01:23:27 UTC
Permalink
Post by Bellegarde Cédric
appmenu/lib/com.canonical.AppMenu.Registrar.xml, line 7
<http://git.reviewboard.kde.org/r/104344/diff/9/?file=56727#file56727line7>
Curious that Canonical is using a Spanish (also Portuguese word) for this :-)
Registrar is an english word ;)
Interesting, I did not know that. I knew "register", but not "registrar".
Post by Bellegarde Cédric
appmenu/lib/importer_interface.h, line 46
<http://git.reviewboard.kde.org/r/104344/diff/9/?file=56728#file56728line46>
QDBusReply and waitForFinished are no go from my part. Please use them only when really really necessary.
I thinks it's needed but i'm rewriting all the code to bypass canonical copyright (and make it more flexible)...
By the way, in krunner-appmenu, i can see reply.waitForFinished(), will talk with A.Fiestas about this issue.
krunner is not the compositor - if it blocks for n seconds, that's a minor and local issue - if kwin blocks for n seconds, that's a major issue.
Therefore blocking dbus calls (where the other side may hang) are no option here.
krunner is also a highly threaded application. So if it's inside a runner, it's just the runner which is blocked. Nevertheless I would love to see only non-blocking D-Bus calls in KDE codebase :-)
I'm sure dbusmenu will not work without a blocking dbus call... (but i may be wrong)...
- Kwin tell kded-appmenu: "Show menu/menubar at position
- Kded popup menu and dbus blocking call should not be a problem
What about this solution ?
Thomas LÃŒbking, kded already has problems with stalls from time to time. Most of the time they do not cause much problems, but sometimes (specially when a plasmoid tries to talk to kded) the stalls can propagate to the entire desktop. In AppMenuModule::slotLayoutUpdated in this patch there is a synchronous dbus call with a 3s timeout. That means that eventually that slot can stall kded for up to 3s everytime there is an update in the mentioned layout.

Martin GrÀßlin, as long as there is no synchronization mechanism (like a QMutex) between the threads then you are right.


- Lamarque Vieira


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review13002
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 16, 2012, 1:55 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Thomas Lübking
2012-07-28 07:12:49 UTC
Permalink
Post by Bellegarde Cédric
appmenu/lib/importer_interface.h, line 46
<http://git.reviewboard.kde.org/r/104344/diff/9/?file=56728#file56728line46>
QDBusReply and waitForFinished are no go from my part. Please use them only when really really necessary.
I thinks it's needed but i'm rewriting all the code to bypass canonical copyright (and make it more flexible)...
By the way, in krunner-appmenu, i can see reply.waitForFinished(), will talk with A.Fiestas about this issue.
krunner is not the compositor - if it blocks for n seconds, that's a minor and local issue - if kwin blocks for n seconds, that's a major issue.
Therefore blocking dbus calls (where the other side may hang) are no option here.
krunner is also a highly threaded application. So if it's inside a runner, it's just the runner which is blocked. Nevertheless I would love to see only non-blocking D-Bus calls in KDE codebase :-)
I'm sure dbusmenu will not work without a blocking dbus call... (but i may be wrong)...
- Kwin tell kded-appmenu: "Show menu/menubar at position
- Kded popup menu and dbus blocking call should not be a problem
What about this solution ?
Thomas LÃŒbking, kded already has problems with stalls from time to time. Most of the time they do not cause much problems, but sometimes (specially when a plasmoid tries to talk to kded) the stalls can propagate to the entire desktop. In AppMenuModule::slotLayoutUpdated in this patch there is a synchronous dbus call with a 3s timeout. That means that eventually that slot can stall kded for up to 3s everytime there is an update in the mentioned layout.
Martin GrÀßlin, as long as there is no synchronization mechanism (like a QMutex) between the threads then you are right.
@Lamarque
That is why you should avoid any sync dbus calls (or sub processes) in a GUI thread, esp. if it has further impact (as plasmoids have on the entire desktop in the present design) or move them to another thread or nested event loop.
Also i don't see me talking about using sync dbus calls in kded ;-)
Post by Bellegarde Cédric
that eventually that slot can stall kded for up to 3s everytime there is an update in the mentioned layout
I've no idea, but would expect kded modules to be threaded??

@Bellegarde
imo in general a reasonable suggestion since kwin would remain being a window manager and not suddenly become a menubar server. The entire thing would then become sth. between the decoration (calling a "random" dbus interface for a button) and kded, kwin doesn't need further modifications. Nevertheless see Lamarques comment.
Post by Bellegarde Cédric
I'm sure dbusmenu will not work without a blocking dbus call
I hope that's not true and from the present issue i would not understand why at all. However in that case i suggest to review and dump the protocol for sth. better. Can you elaborate on why you assume sync dbus calls are mandatory for dbusmenu? (or do you just mean the dbusmenu-qt implementation just uses them without sense, in which case that should be fixed)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review13002
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 16, 2012, 1:55 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Lamarque Vieira Souza
2012-07-28 15:56:26 UTC
Permalink
Post by Bellegarde Cédric
appmenu/lib/importer_interface.h, line 46
<http://git.reviewboard.kde.org/r/104344/diff/9/?file=56728#file56728line46>
QDBusReply and waitForFinished are no go from my part. Please use them only when really really necessary.
I thinks it's needed but i'm rewriting all the code to bypass canonical copyright (and make it more flexible)...
By the way, in krunner-appmenu, i can see reply.waitForFinished(), will talk with A.Fiestas about this issue.
krunner is not the compositor - if it blocks for n seconds, that's a minor and local issue - if kwin blocks for n seconds, that's a major issue.
Therefore blocking dbus calls (where the other side may hang) are no option here.
krunner is also a highly threaded application. So if it's inside a runner, it's just the runner which is blocked. Nevertheless I would love to see only non-blocking D-Bus calls in KDE codebase :-)
I'm sure dbusmenu will not work without a blocking dbus call... (but i may be wrong)...
- Kwin tell kded-appmenu: "Show menu/menubar at position
- Kded popup menu and dbus blocking call should not be a problem
What about this solution ?
Thomas LÃŒbking, kded already has problems with stalls from time to time. Most of the time they do not cause much problems, but sometimes (specially when a plasmoid tries to talk to kded) the stalls can propagate to the entire desktop. In AppMenuModule::slotLayoutUpdated in this patch there is a synchronous dbus call with a 3s timeout. That means that eventually that slot can stall kded for up to 3s everytime there is an update in the mentioned layout.
Martin GrÀßlin, as long as there is no synchronization mechanism (like a QMutex) between the threads then you are right.
@Lamarque
That is why you should avoid any sync dbus calls (or sub processes) in a GUI thread, esp. if it has further impact (as plasmoids have on the entire desktop in the present design) or move them to another thread or nested event loop.
Also i don't see me talking about using sync dbus calls in kded ;-)
that eventually that slot can stall kded for up to 3s everytime there is an update in the mentioned layout
I've no idea, but would expect kded modules to be threaded??
@Bellegarde
imo in general a reasonable suggestion since kwin would remain being a window manager and not suddenly become a menubar server. The entire thing would then become sth. between the decoration (calling a "random" dbus interface for a button) and kded, kwin doesn't need further modifications. Nevertheless see Lamarques comment.
I'm sure dbusmenu will not work without a blocking dbus call
I hope that's not true and from the present issue i would not understand why at all. However in that case i suggest to review and dump the protocol for sth. better. Can you elaborate on why you assume sync dbus calls are mandatory for dbusmenu? (or do you just mean the dbusmenu-qt implementation just uses them without sense, in which case that should be fixed)
I've no idea, but would expect kded modules to be threaded??
well, I guess most kded modules are not threaded and the one in this patch also does not seem threaded. I think most developers that implement a kded do not even think about using threads, so we need to warn them from time to time. Thanks for suggesting using threads here :-)
Post by Bellegarde Cédric
Can you elaborate on why you assume sync dbus calls are mandatory for dbusmenu?
The sync dbus call spotted here came from an automatic generated header using qdbusxml2cpp, so we cannot change it unless we change the dbusmenu specification.


- Lamarque Vieira


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review13002
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 16, 2012, 1:55 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Thomas Lübking
2012-07-28 16:17:30 UTC
Permalink
Post by Bellegarde Cédric
appmenu/lib/importer_interface.h, line 46
<http://git.reviewboard.kde.org/r/104344/diff/9/?file=56728#file56728line46>
QDBusReply and waitForFinished are no go from my part. Please use them only when really really necessary.
I thinks it's needed but i'm rewriting all the code to bypass canonical copyright (and make it more flexible)...
By the way, in krunner-appmenu, i can see reply.waitForFinished(), will talk with A.Fiestas about this issue.
krunner is not the compositor - if it blocks for n seconds, that's a minor and local issue - if kwin blocks for n seconds, that's a major issue.
Therefore blocking dbus calls (where the other side may hang) are no option here.
krunner is also a highly threaded application. So if it's inside a runner, it's just the runner which is blocked. Nevertheless I would love to see only non-blocking D-Bus calls in KDE codebase :-)
I'm sure dbusmenu will not work without a blocking dbus call... (but i may be wrong)...
- Kwin tell kded-appmenu: "Show menu/menubar at position
- Kded popup menu and dbus blocking call should not be a problem
What about this solution ?
Thomas LÃŒbking, kded already has problems with stalls from time to time. Most of the time they do not cause much problems, but sometimes (specially when a plasmoid tries to talk to kded) the stalls can propagate to the entire desktop. In AppMenuModule::slotLayoutUpdated in this patch there is a synchronous dbus call with a 3s timeout. That means that eventually that slot can stall kded for up to 3s everytime there is an update in the mentioned layout.
Martin GrÀßlin, as long as there is no synchronization mechanism (like a QMutex) between the threads then you are right.
@Lamarque
That is why you should avoid any sync dbus calls (or sub processes) in a GUI thread, esp. if it has further impact (as plasmoids have on the entire desktop in the present design) or move them to another thread or nested event loop.
Also i don't see me talking about using sync dbus calls in kded ;-)
that eventually that slot can stall kded for up to 3s everytime there is an update in the mentioned layout
I've no idea, but would expect kded modules to be threaded??
@Bellegarde
imo in general a reasonable suggestion since kwin would remain being a window manager and not suddenly become a menubar server. The entire thing would then become sth. between the decoration (calling a "random" dbus interface for a button) and kded, kwin doesn't need further modifications. Nevertheless see Lamarques comment.
I'm sure dbusmenu will not work without a blocking dbus call
I hope that's not true and from the present issue i would not understand why at all. However in that case i suggest to review and dump the protocol for sth. better. Can you elaborate on why you assume sync dbus calls are mandatory for dbusmenu? (or do you just mean the dbusmenu-qt implementation just uses them without sense, in which case that should be fixed)
I've no idea, but would expect kded modules to be threaded??
well, I guess most kded modules are not threaded and the one in this patch also does not seem threaded. I think most developers that implement a kded do not even think about using threads, so we need to warn them from time to time. Thanks for suggesting using threads here :-)
Can you elaborate on why you assume sync dbus calls are mandatory for dbusmenu?
The sync dbus call spotted here came from an automatic generated header using qdbusxml2cpp, so we cannot change it unless we change the dbusmenu specification.
I guess most kded modules are not threaded
I expected *kded* to run modules in threads (if you run 3rd party stuff of uncertain quality, thats rather mandatory)
Post by Bellegarde Cédric
The sync dbus call spotted here came from an automatic generated header using qdbusxml2cpp
yesno - you're aware of "QDBusPendingCall QDBusAbstractInterface::asyncCall(.)"?
Check QDebugPendingReply doc for details on invocation.

Unless the protocol is actually stupid enough to require a synchronous operation (ie. if the client does sth. async and uses that the server may invalidate or crash or similar or vv.) there's no need to perform sync dbus operations - and one should not, regardless of the application, but esp. not in any GUI thread.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review13002
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 16, 2012, 1:55 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Lamarque Vieira Souza
2012-07-28 16:41:55 UTC
Permalink
Post by Bellegarde Cédric
appmenu/lib/importer_interface.h, line 46
<http://git.reviewboard.kde.org/r/104344/diff/9/?file=56728#file56728line46>
QDBusReply and waitForFinished are no go from my part. Please use them only when really really necessary.
I thinks it's needed but i'm rewriting all the code to bypass canonical copyright (and make it more flexible)...
By the way, in krunner-appmenu, i can see reply.waitForFinished(), will talk with A.Fiestas about this issue.
krunner is not the compositor - if it blocks for n seconds, that's a minor and local issue - if kwin blocks for n seconds, that's a major issue.
Therefore blocking dbus calls (where the other side may hang) are no option here.
krunner is also a highly threaded application. So if it's inside a runner, it's just the runner which is blocked. Nevertheless I would love to see only non-blocking D-Bus calls in KDE codebase :-)
I'm sure dbusmenu will not work without a blocking dbus call... (but i may be wrong)...
- Kwin tell kded-appmenu: "Show menu/menubar at position
- Kded popup menu and dbus blocking call should not be a problem
What about this solution ?
Thomas LÃŒbking, kded already has problems with stalls from time to time. Most of the time they do not cause much problems, but sometimes (specially when a plasmoid tries to talk to kded) the stalls can propagate to the entire desktop. In AppMenuModule::slotLayoutUpdated in this patch there is a synchronous dbus call with a 3s timeout. That means that eventually that slot can stall kded for up to 3s everytime there is an update in the mentioned layout.
Martin GrÀßlin, as long as there is no synchronization mechanism (like a QMutex) between the threads then you are right.
@Lamarque
That is why you should avoid any sync dbus calls (or sub processes) in a GUI thread, esp. if it has further impact (as plasmoids have on the entire desktop in the present design) or move them to another thread or nested event loop.
Also i don't see me talking about using sync dbus calls in kded ;-)
that eventually that slot can stall kded for up to 3s everytime there is an update in the mentioned layout
I've no idea, but would expect kded modules to be threaded??
@Bellegarde
imo in general a reasonable suggestion since kwin would remain being a window manager and not suddenly become a menubar server. The entire thing would then become sth. between the decoration (calling a "random" dbus interface for a button) and kded, kwin doesn't need further modifications. Nevertheless see Lamarques comment.
I'm sure dbusmenu will not work without a blocking dbus call
I hope that's not true and from the present issue i would not understand why at all. However in that case i suggest to review and dump the protocol for sth. better. Can you elaborate on why you assume sync dbus calls are mandatory for dbusmenu? (or do you just mean the dbusmenu-qt implementation just uses them without sense, in which case that should be fixed)
I've no idea, but would expect kded modules to be threaded??
well, I guess most kded modules are not threaded and the one in this patch also does not seem threaded. I think most developers that implement a kded do not even think about using threads, so we need to warn them from time to time. Thanks for suggesting using threads here :-)
Can you elaborate on why you assume sync dbus calls are mandatory for dbusmenu?
The sync dbus call spotted here came from an automatic generated header using qdbusxml2cpp, so we cannot change it unless we change the dbusmenu specification.
I guess most kded modules are not threaded
I expected *kded* to run modules in threads (if you run 3rd party stuff of uncertain quality, thats rather mandatory)
The sync dbus call spotted here came from an automatic generated header using qdbusxml2cpp
yesno - you're aware of "QDBusPendingCall QDBusAbstractInterface::asyncCall(.)"?
Check QDebugPendingReply doc for details on invocation.
Unless the protocol is actually stupid enough to require a synchronous operation (ie. if the client does sth. async and uses that the server may invalidate or crash or similar or vv.) there's no need to perform sync dbus operations - and one should not, regardless of the application, but esp. not in any GUI thread.
I expected *kded* to run modules in threads (if you run 3rd party stuff of uncertain quality, thats rather mandatory)
Ah, ok then. Now you know kded is not threaded :-/

I am aware of QDBusAbstractInterface::asyncCall() but programs may not work properly if the other end of the dbus call is not prepared to handle async calls, right? Anyway, there is an async version of this call some lines above, so as long as nobody uses this sync version it should be ok.


- Lamarque Vieira


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review13002
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 16, 2012, 1:55 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Martin Gräßlin
2012-07-22 17:21:50 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review16211
-----------------------------------------------------------


I just wanted to ask what's the current state of this project. Master is open again and I would prefer to see this go into a mergable state early in the cycle :-)

- Martin GrÀßlin
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 16, 2012, 1:55 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-07-26 21:05:52 UTC
Permalink
Post by Bellegarde Cédric
Post by Martin Gräßlin
I just wanted to ask what's the current state of this project. Master is open again and I would prefer to see this go into a mergable state early in the cycle :-)
In hollidays for one month, will try to works on kded module soon to fix issues...

I may remove link to libdusmenu and use krunner-appmenu code as a base.


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review16211
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated April 16, 2012, 1:55 p.m.)
Review request for kwin.
Description
-------
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
http://youtu.be/j0o1sRLRc60
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad
Diffs
-----
CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-08-17 16:21:13 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated Aug. 17, 2012, 4:21 p.m.)


Review request for kwin.


Changes
-------

New version here:
http://kde-look.org/content/show.php/kded-appmenu?content=153417

Kwin can only show standard QMenu when clicking on button (much more consistent).

Add an option to kded-appmenu to display an auto hiding top menubar with glow effect when hidden

Configuration is now in kcm_style after toolbar configuration, better like this i think.


Description (updated)
-------

Here a patch to add appmenu support to kwin via a menu button in titlebar

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

It looks like this:


New version, all drawing code moved to kded-appmenu as asked.


Diffs
-----

CMakeLists.txt 1385cb6
appmenu/CMakeLists.txt PRE-CREATION
appmenu/lib/CMakeLists.txt PRE-CREATION
appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/lib/importer_interface.h PRE-CREATION
appmenu/lib/importer_interface.cpp PRE-CREATION
appmenu/lib/kappmenu_export.h PRE-CREATION
appmenu/lib/kappmenuimporter.h PRE-CREATION
appmenu/lib/kappmenuimporter.cpp PRE-CREATION
appmenu/lib/menuinfo.h PRE-CREATION
appmenu/module/CMakeLists.txt PRE-CREATION
appmenu/module/appmenu.h PRE-CREATION
appmenu/module/appmenu.cpp PRE-CREATION
appmenu/module/appmenu.desktop PRE-CREATION
appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
appmenu/module/registrar.h PRE-CREATION
appmenu/module/registrar.cpp PRE-CREATION
kwin/CMakeLists.txt 6e29be2
kwin/bridge.h 64108e5
kwin/bridge.cpp 897d432
kwin/client.h 2f55087
kwin/client.cpp 410ff43
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h e1d1d0a
kwin/clients/oxygen/oxygenclient.cpp 7a2b021
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 827aa59
kwin/config-kwin.h.cmake 49b643a
kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
kwin/kwin.kcfg cf6537e
kwin/kwinbindings.cpp 3284cf0
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 442d0a1
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/menubar.h PRE-CREATION
kwin/menubar.cpp PRE-CREATION
kwin/options.h 855ed78
kwin/options.cpp a250e79
kwin/scripting/workspace_wrapper.h 76d60bf
kwin/scripting/workspace_wrapper.cpp c5b684a
kwin/useractions.cpp 09e18c3
kwin/workspace.h 9df435c
kwin/workspace.cpp b5c8014

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Bellegarde Cédric
2012-08-17 16:28:31 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated Aug. 17, 2012, 4:28 p.m.)


Review request for kwin.


Changes
-------

New patch version


Description
-------

Here a patch to add appmenu support to kwin via a menu button in titlebar

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

It looks like this:
http://youtu.be/x1bm7Q6_SH4

New version, all drawing code moved to kded-appmenu as asked.


Diffs (updated)
-----

kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 5f281b8
kwin/workspace.cpp ecf0d76

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Martin Gräßlin
2012-08-20 19:15:34 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review17772
-----------------------------------------------------------


Main remark is that the libkdecorations should not use the ifdef. Reason is given below in the review comments.


kwin/CMakeLists.txt
<http://git.reviewboard.kde.org/r/104344/#comment13962>

I would suggest to bind the option with KWIN_BUILD_DECORATIONS. Feature seems useless to me if we don't have decos. So maybe an

if (NOT KWIN_BUILD_DECORATIONS)
set(KWIN_BUILD_KAPPMENU OFF)
endif (NOT KWIN_BUILD_DECORATIONS)



kwin/client.h
<http://git.reviewboard.kde.org/r/104344/#comment13964>

trailing whitespace



kwin/libkdecorations/kcommondecoration.cpp
<http://git.reviewboard.kde.org/r/104344/#comment13972>

trailing whitespace



kwin/libkdecorations/kcommondecoration.cpp
<http://git.reviewboard.kde.org/r/104344/#comment13970>

trailing whitespace



kwin/libkdecorations/kcommondecoration.cpp
<http://git.reviewboard.kde.org/r/104344/#comment13971>

trailing whitespace



kwin/libkdecorations/kdecoration.h
<http://git.reviewboard.kde.org/r/104344/#comment13969>

in the public library the ifdef may not be added. A decoration might have been built against a lib with the ifdef, but the KWin it's run in lateron without.

That of course applies to all the ifdef blocks in this lib.



kwin/libkdecorations/kdecoration.cpp
<http://git.reviewboard.kde.org/r/104344/#comment13975>

is there a reason why you do the disconnect in the dtor? I would assume that QObject handles the disconnect automatically



kwin/workspace.h
<http://git.reviewboard.kde.org/r/104344/#comment13974>

is that really a window ID? If yes better use the datatype WId or qulonglong. A uint is clearly too short to store a window ID.



kwin/workspace.h
<http://git.reviewboard.kde.org/r/104344/#comment13973>

be careful with your datatype. in slotMenuAvailable it's a uint while here it is an int.

I completely fail to understand what this list is about and why sometimes something is stored in there and sometimes not.



kwin/workspace.cpp
<http://git.reviewboard.kde.org/r/104344/#comment13965>

trailing whitespaces



kwin/workspace.cpp
<http://git.reviewboard.kde.org/r/104344/#comment13967>

you want to check out Workspace::findClient() :-)


- Martin GrÀßlin
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 17, 2012, 4:28 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 5f281b8
kwin/workspace.cpp ecf0d76
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Thomas Lübking
2012-08-20 20:30:11 UTC
Permalink
Post by Bellegarde Cédric
kwin/workspace.h, line 931
<http://git.reviewboard.kde.org/r/104344/diff/10/?file=78246#file78246line931>
be careful with your datatype. in slotMenuAvailable it's a uint while here it is an int.
I completely fail to understand what this list is about and why sometimes something is stored in there and sometimes not.
Looks like a cache when the ded emits the availability of a menu but the window is not yet managed (apparently to avoid sync dbus calls as well as threads)

@Cédric (hoping that's your first name ;-)
how are kwin restarts covered (like after a crash or when altering the graphicssystem - or because you're a kwin developer and restart it ~200 times a day ;-)
Eg. i don't see the code calling some trigger (send all available menus now or so) on kded


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review17772
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 17, 2012, 4:28 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 5f281b8
kwin/workspace.cpp ecf0d76
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-08-22 14:16:09 UTC
Permalink
Post by Bellegarde Cédric
kwin/libkdecorations/kdecoration.cpp, lines 87-88
<http://git.reviewboard.kde.org/r/104344/diff/10/?file=78245#file78245line87>
is there a reason why you do the disconnect in the dtor? I would assume that QObject handles the disconnect automatically
Ok, will note that's this is not needed


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review17772
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 17, 2012, 4:28 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 5f281b8
kwin/workspace.cpp ecf0d76
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-08-22 15:38:55 UTC
Permalink
Post by Thomas Lübking
kwin/workspace.h, line 651
<http://git.reviewboard.kde.org/r/104344/diff/10/?file=78246#file78246line651>
is that really a window ID? If yes better use the datatype WId or qulonglong. A uint is clearly too short to store a window ID.
I modify this part and use qulonglong in:
- kded-appmenu
- dbus interface (t)
- this patch

But it's really strange, dbusmenu registrar seems to use uint for window id, any idea why ?
Post by Thomas Lübking
kwin/workspace.h, line 931
<http://git.reviewboard.kde.org/r/104344/diff/10/?file=78246#file78246line931>
be careful with your datatype. in slotMenuAvailable it's a uint while here it is an int.
I completely fail to understand what this list is about and why sometimes something is stored in there and sometimes not.
Looks like a cache when the ded emits the availability of a menu but the window is not yet managed (apparently to avoid sync dbus calls as well as threads)
@Cédric (hoping that's your first name ;-)
how are kwin restarts covered (like after a crash or when altering the graphicssystem - or because you're a kwin developer and restart it ~200 times a day ;-)
Eg. i don't see the code calling some trigger (send all available menus now or so) on kded
No trigger for now...

I've got an issue with KDE 4.9 and later, when restarting kwin, application menu button is shown on all existing windows and i can't figure why... Help is welcome.


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review17772
-----------------------------------------------------------
Post by Thomas Lübking
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 22, 2012, 3:35 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-08-22 15:35:51 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated Aug. 22, 2012, 3:35 p.m.)


Review request for kwin.


Changes
-------

Fix some issues...


Description
-------

Here a patch to add appmenu support to kwin via a menu button in titlebar

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

It looks like this:
http://youtu.be/x1bm7Q6_SH4

New version, all drawing code moved to kded-appmenu as asked.


Diffs (updated)
-----

kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Thomas Lübking
2012-08-22 18:25:34 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review17872
-----------------------------------------------------------



kwin/libkdecorations/kcommondecoration.cpp
<http://git.reviewboard.kde.org/r/104344/#comment14115>

I'm not really keen in KCommonDecoration, but i guess this is wrong.

Unless the button widget was explicitly reparented it's added to it's parent visible (just think of GUI code if it was not) so you'll have to explicitly hide() your button here (and that's probably because you see it initially)



kwin/libkdecorations/kcommondecoration.cpp
<http://git.reviewboard.kde.org/r/104344/#comment14113>

spare the "else"



kwin/libkdecorations/kcommondecoration.cpp
<http://git.reviewboard.kde.org/r/104344/#comment14114>

this is brainf*** ;-)

if (!m_menuAvailable)
return;

m_menuAvailable = false;
...


- Thomas LÃŒbking
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 22, 2012, 3:35 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-08-23 10:13:58 UTC
Permalink
Post by Bellegarde Cédric
kwin/libkdecorations/kcommondecoration.cpp, line 825
<http://git.reviewboard.kde.org/r/104344/diff/11/?file=79981#file79981line825>
this is brainf*** ;-)
if (!m_menuAvailable)
return;
m_menuAvailable = false;
...
Hmm, need to sleep sometimes... ;)
Post by Bellegarde Cédric
kwin/libkdecorations/kcommondecoration.cpp, line 545
<http://git.reviewboard.kde.org/r/104344/diff/11/?file=79981#file79981line545>
I'm not really keen in KCommonDecoration, but i guess this is wrong.
Unless the button widget was explicitly reparented it's added to it's parent visible (just think of GUI code if it was not) so you'll have to explicitly hide() your button here (and that's probably because you see it initially)
You are right, for a strange reason, it was working with KDE 4.8...


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review17872
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 22, 2012, 3:35 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-08-23 10:35:30 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated Aug. 23, 2012, 10:35 a.m.)


Review request for kwin.


Changes
-------

- Fix Brain Fuck code :)
- Fix unhidden buttons at kwin restart

No need to look for availables menus on kwin restart, dbusmenu registrar emit a "RegisterWindow" signal and so kded-appmenu emit a "menuAvailable" signal on kwin startup.


Description
-------

Here a patch to add appmenu support to kwin via a menu button in titlebar

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

It looks like this:
http://youtu.be/x1bm7Q6_SH4

New version, all drawing code moved to kded-appmenu as asked.


Diffs (updated)
-----

kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Bellegarde Cédric
2012-08-23 13:35:16 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated Aug. 23, 2012, 1:35 p.m.)


Review request for kwin.


Changes
-------

Remove invalid include in kdecoration.h


Description
-------

Here a patch to add appmenu support to kwin via a menu button in titlebar

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

It looks like this:
http://youtu.be/x1bm7Q6_SH4

New version, all drawing code moved to kded-appmenu as asked.


Diffs (updated)
-----

kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Bellegarde Cédric
2012-08-23 21:20:51 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated Aug. 23, 2012, 9:20 p.m.)


Review request for kwin.


Changes
-------

Fix menu position (last code was working due to a bug in kded-appmenu)


Description
-------

Here a patch to add appmenu support to kwin via a menu button in titlebar

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

It looks like this:
http://youtu.be/x1bm7Q6_SH4

New version, all drawing code moved to kded-appmenu as asked.


Diffs (updated)
-----

kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Bellegarde Cédric
2012-08-26 11:57:53 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18031
-----------------------------------------------------------


There is a problem with the #include "kwin-config.h" in kcommondecoration.h when building externals decorations, how to fix it ?

- Bellegarde Cédric
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 23, 2012, 9:20 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Thomas Lübking
2012-08-26 13:10:41 UTC
Permalink
Post by Bellegarde Cédric
Post by Bellegarde Cédric
There is a problem with the #include "kwin-config.h" in kcommondecoration.h when building externals decorations, how to fix it ?
remove it alongside the preprocessor checks.
Such does not belong into a public API or any exported class (breaks ABI compatibility if you compile w/ appmenu enabled and someone tries to use the deco on a binary compiled w/o support)

You need to leave the signatures in the header and #ifdef the function block in the sources:

void Foo::bar()
{
#ifdef FOO_BAR
forBar();
#endif
}


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18031
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 23, 2012, 9:20 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Thomas Lübking
2012-08-26 13:07:48 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18032
-----------------------------------------------------------



kwin/client.h
<http://git.reviewboard.kde.org/r/104344/#comment14247>

why this?
just emit in the code - also the function name does not match conventions (sounds like a getter)


- Thomas LÃŒbking
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 23, 2012, 9:20 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-08-27 13:28:06 UTC
Permalink
Post by Bellegarde Cédric
kwin/client.h, line 646
<http://git.reviewboard.kde.org/r/104344/diff/14/?file=80446#file80446line646>
why this?
just emit in the code - also the function name does not match conventions (sounds like a getter)
This function is called by Workspace not by clients and signal is protected . Another solution ?

Function renamed.


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18032
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 23, 2012, 9:20 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-08-26 16:23:18 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18037
-----------------------------------------------------------


I've got another issue, when i call menu->popup(position) from kded module, menu doesn't get focus and doesn't close when clicking elsewhere...

Calling setWindowState(Qt::WindowActive) fix issue but only works one time...

void AppMenuModule::showVerticalMenu(QMenu* menu, QPoint p)
{
//FIXME seems to make popup get focus the first time it is shown
// Not working on second popup()
menu->setWindowState(Qt::WindowActive);
menu->popup(p);
if (m_waitingAction)
menu->setActiveAction(m_waitingAction);
connect(menu, SIGNAL(aboutToHide()), this, SLOT(slotAboutToHide()));
}

[15:56] <thiago> gnumdk: X11 has a major feature lack there
[15:56] <thiago> it's fixed on Wayland
[15:56] <thiago> until then, you need to cope with the issue and not try to acquire grabs if you can avoid it

But i don't know how to cope with the issue :( Any idea ?



- Bellegarde Cédric
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 23, 2012, 9:20 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Thomas Lübking
2012-08-26 21:47:40 UTC
Permalink
Post by Bellegarde Cédric
Post by Bellegarde Cédric
I've got another issue, when i call menu->popup(position) from kded module, menu doesn't get focus and doesn't close when clicking elsewhere...
Calling setWindowState(Qt::WindowActive) fix issue but only works one time...
void AppMenuModule::showVerticalMenu(QMenu* menu, QPoint p)
{
//FIXME seems to make popup get focus the first time it is shown
// Not working on second popup()
menu->setWindowState(Qt::WindowActive);
menu->popup(p);
if (m_waitingAction)
menu->setActiveAction(m_waitingAction);
connect(menu, SIGNAL(aboutToHide()), this, SLOT(slotAboutToHide()));
}
[15:56] <thiago> gnumdk: X11 has a major feature lack there
[15:56] <thiago> it's fixed on Wayland
[15:56] <thiago> until then, you need to cope with the issue and not try to acquire grabs if you can avoid it
But i don't know how to cope with the issue :( Any idea ?
what's special about the menu (why is it synthetic) - or are input devices grabbed otherwise (or does kded run --nograb?)

If possible, grab pointer & keyboard yourself and pass all relevant events down to the menu.
Menus never get the keyboard focus (easily) and you should likely set the state _after_ the popup.
However w/o grabbing the mouse you cannot exit the menu on outside clicks.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18037
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 23, 2012, 9:20 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-08-27 09:11:00 UTC
Permalink
Post by Thomas Lübking
Post by Bellegarde Cédric
I've got another issue, when i call menu->popup(position) from kded module, menu doesn't get focus and doesn't close when clicking elsewhere...
Calling setWindowState(Qt::WindowActive) fix issue but only works one time...
void AppMenuModule::showVerticalMenu(QMenu* menu, QPoint p)
{
//FIXME seems to make popup get focus the first time it is shown
// Not working on second popup()
menu->setWindowState(Qt::WindowActive);
menu->popup(p);
if (m_waitingAction)
menu->setActiveAction(m_waitingAction);
connect(menu, SIGNAL(aboutToHide()), this, SLOT(slotAboutToHide()));
}
[15:56] <thiago> gnumdk: X11 has a major feature lack there
[15:56] <thiago> it's fixed on Wayland
[15:56] <thiago> until then, you need to cope with the issue and not try to acquire grabs if you can avoid it
But i don't know how to cope with the issue :( Any idea ?
what's special about the menu (why is it synthetic) - or are input devices grabbed otherwise (or does kded run --nograb?)
If possible, grab pointer & keyboard yourself and pass all relevant events down to the menu.
Menus never get the keyboard focus (easily) and you should likely set the state _after_ the popup.
However w/o grabbing the mouse you cannot exit the menu on outside clicks.
Why was this working with just DbusMenu::QMenu::popup() with old patch version (popup code in workspace.cpp) ?


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18037
-----------------------------------------------------------
Post by Thomas Lübking
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 23, 2012, 9:20 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-08-27 13:29:48 UTC
Permalink
Post by Thomas Lübking
Post by Bellegarde Cédric
I've got another issue, when i call menu->popup(position) from kded module, menu doesn't get focus and doesn't close when clicking elsewhere...
Calling setWindowState(Qt::WindowActive) fix issue but only works one time...
void AppMenuModule::showVerticalMenu(QMenu* menu, QPoint p)
{
//FIXME seems to make popup get focus the first time it is shown
// Not working on second popup()
menu->setWindowState(Qt::WindowActive);
menu->popup(p);
if (m_waitingAction)
menu->setActiveAction(m_waitingAction);
connect(menu, SIGNAL(aboutToHide()), this, SLOT(slotAboutToHide()));
}
[15:56] <thiago> gnumdk: X11 has a major feature lack there
[15:56] <thiago> it's fixed on Wayland
[15:56] <thiago> until then, you need to cope with the issue and not try to acquire grabs if you can avoid it
But i don't know how to cope with the issue :( Any idea ?
what's special about the menu (why is it synthetic) - or are input devices grabbed otherwise (or does kded run --nograb?)
If possible, grab pointer & keyboard yourself and pass all relevant events down to the menu.
Menus never get the keyboard focus (easily) and you should likely set the state _after_ the popup.
However w/o grabbing the mouse you cannot exit the menu on outside clicks.
Why was this working with just DbusMenu::QMenu::popup() with old patch version (popup code in workspace.cpp) ?
Ok, fixed in current git, setWindowState() adds Qt::X11BypassWindowManagerHint making setWindowState not working next popup() time.


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18037
-----------------------------------------------------------
Post by Thomas Lübking
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 23, 2012, 9:20 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Lamarque Vieira Souza
2012-08-27 01:07:08 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18066
-----------------------------------------------------------



kwin/clients/oxygen/oxygenbutton.cpp
<http://git.reviewboard.kde.org/r/104344/#comment14304>

remove trailing whitespace.



kwin/kcmkwin/kwindecoration/buttons.cpp
<http://git.reviewboard.kde.org/r/104344/#comment14305>

This line should have one tab identation less so that it is aligned to the line below. Also use white space after '(' and before ')' here but not in the lines below, you should stick to one code style only.



kwin/libkdecorations/kcommondecoration.cpp
<http://git.reviewboard.kde.org/r/104344/#comment14306>

Stick to the code style here, use if (...) {
} else {
}


- Lamarque Vieira Souza
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 23, 2012, 9:20 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-08-27 13:40:43 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated Aug. 27, 2012, 1:40 p.m.)


Review request for kwin.


Description
-------

Here a patch to add appmenu support to kwin via a menu button in titlebar

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

It looks like this:
http://youtu.be/x1bm7Q6_SH4

New version, all drawing code moved to kded-appmenu as asked.


Diffs (updated)
-----

kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Bellegarde Cédric
2012-08-27 14:02:45 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated Aug. 27, 2012, 2:02 p.m.)


Review request for kwin.


Changes
-------

Fix <kwin-config.h> issue


Description
-------

Here a patch to add appmenu support to kwin via a menu button in titlebar

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

It looks like this:
http://youtu.be/x1bm7Q6_SH4

New version, all drawing code moved to kded-appmenu as asked.


Diffs (updated)
-----

kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Bellegarde Cédric
2012-08-28 10:06:54 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18156
-----------------------------------------------------------


Ok more information about QMenu focus issue...

Kded-appmenu do not have any bug with this, when calling showMenu with qdbus, it's working...

The bug seems to be in this patch but don't know why... Like if kwin was grabing mouse+keyboard while a button is pressed, is this true ?

- Bellegarde Cédric
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 27, 2012, 2:02 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Thomas Lübking
2012-08-28 10:21:57 UTC
Permalink
Post by Bellegarde Cédric
Post by Bellegarde Cédric
Ok more information about QMenu focus issue...
Kded-appmenu do not have any bug with this, when calling showMenu with qdbus, it's working...
The bug seems to be in this patch but don't know why... Like if kwin was grabing mouse+keyboard while a button is pressed, is this true ?
don`t think so, but qabstactbutton likely will - and kcommondecorationbutton is one


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18156
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 27, 2012, 2:02 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-08-28 13:51:25 UTC
Permalink
Post by Thomas Lübking
Post by Bellegarde Cédric
Ok more information about QMenu focus issue...
Kded-appmenu do not have any bug with this, when calling showMenu with qdbus, it's working...
The bug seems to be in this patch but don't know why... Like if kwin was grabing mouse+keyboard while a button is pressed, is this true ?
don`t think so, but qabstactbutton likely will - and kcommondecorationbutton is one
I've looked at qabstractbutton code and can't find any mouse+keyboard grabing...

It seems that kwin while buttons clicked do not accept focus change from clients.

I try to connect appMenuButtonPressed() to released() signal with no luck.

Showing menu when it become available (so without click) works.

Help is really welcome.


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18156
-----------------------------------------------------------
Post by Thomas Lübking
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 27, 2012, 2:02 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Thomas Lübking
2012-08-28 16:47:59 UTC
Permalink
Post by Thomas Lübking
Post by Bellegarde Cédric
Ok more information about QMenu focus issue...
Kded-appmenu do not have any bug with this, when calling showMenu with qdbus, it's working...
The bug seems to be in this patch but don't know why... Like if kwin was grabing mouse+keyboard while a button is pressed, is this true ?
don`t think so, but qabstactbutton likely will - and kcommondecorationbutton is one
I've looked at qabstractbutton code and can't find any mouse+keyboard grabing...
It seems that kwin while buttons clicked do not accept focus change from clients.
I try to connect appMenuButtonPressed() to released() signal with no luck.
Showing menu when it become available (so without click) works.
Help is really welcome.
this is not about focus at all - popups _never_ get the focus but gain it for server exclusive input handling (ie. grabbing input)

when attempting the grabfailing input event, check for qDebug() << QWidget::mouseGrabber() to see what currently has the mouse.
If there's none, kwin is not the issue (and pot. not even input grabbing)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18156
-----------------------------------------------------------
Post by Thomas Lübking
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 27, 2012, 2:02 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-08-30 08:29:23 UTC
Permalink
Post by Thomas Lübking
Post by Bellegarde Cédric
Ok more information about QMenu focus issue...
Kded-appmenu do not have any bug with this, when calling showMenu with qdbus, it's working...
The bug seems to be in this patch but don't know why... Like if kwin was grabing mouse+keyboard while a button is pressed, is this true ?
don`t think so, but qabstactbutton likely will - and kcommondecorationbutton is one
I've looked at qabstractbutton code and can't find any mouse+keyboard grabing...
It seems that kwin while buttons clicked do not accept focus change from clients.
I try to connect appMenuButtonPressed() to released() signal with no luck.
Showing menu when it become available (so without click) works.
Help is really welcome.
this is not about focus at all - popups _never_ get the focus but gain it for server exclusive input handling (ie. grabbing input)
when attempting the grabfailing input event, check for qDebug() << QWidget::mouseGrabber() to see what currently has the mouse.
If there's none, kwin is not the issue (and pot. not even input grabbing)
Ok, it seems that QMenu only grabs input on fist show() but fails on laters...

This python code show issue. First time menu is shown, input is grabbed, second time it fails...

Is this a Qt Bug or am i missing something ?

#!/usr/bin/python2
# -*- coding: utf-8 -*-
import sys
from PyQt4.QtGui import QApplication, QErrorMessage
from PyQt4.QtCore import *
from PyQt4.QtGui import *
import thread
import time

if __name__ == '__main__':
app = QApplication(sys.argv)
menu = QMenu()
menu.addAction("plop")
menu.addAction("plop")
menu.addAction("plop")
menu.addAction("plop")
menu.popup(QPoint(100,100))
time.sleep(5)
menu.hide()
time.sleep(5)
menu.popup(QPoint(100,100))
res = app.exec_()
sys.exit(res)


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18156
-----------------------------------------------------------
Post by Thomas Lübking
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 27, 2012, 2:02 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-08-31 07:41:57 UTC
Permalink
Post by Thomas Lübking
Post by Bellegarde Cédric
Ok more information about QMenu focus issue...
Kded-appmenu do not have any bug with this, when calling showMenu with qdbus, it's working...
The bug seems to be in this patch but don't know why... Like if kwin was grabing mouse+keyboard while a button is pressed, is this true ?
don`t think so, but qabstactbutton likely will - and kcommondecorationbutton is one
I've looked at qabstractbutton code and can't find any mouse+keyboard grabing...
It seems that kwin while buttons clicked do not accept focus change from clients.
I try to connect appMenuButtonPressed() to released() signal with no luck.
Showing menu when it become available (so without click) works.
Help is really welcome.
this is not about focus at all - popups _never_ get the focus but gain it for server exclusive input handling (ie. grabbing input)
when attempting the grabfailing input event, check for qDebug() << QWidget::mouseGrabber() to see what currently has the mouse.
If there's none, kwin is not the issue (and pot. not even input grabbing)
Ok, it seems that QMenu only grabs input on fist show() but fails on laters...
This python code show issue. First time menu is shown, input is grabbed, second time it fails...
Is this a Qt Bug or am i missing something ?
#!/usr/bin/python2
# -*- coding: utf-8 -*-
import sys
from PyQt4.QtGui import QApplication, QErrorMessage
from PyQt4.QtCore import *
from PyQt4.QtGui import *
import thread
import time
app = QApplication(sys.argv)
menu = QMenu()
menu.addAction("plop")
menu.addAction("plop")
menu.addAction("plop")
menu.addAction("plop")
menu.popup(QPoint(100,100))
time.sleep(5)
menu.hide()
time.sleep(5)
menu.popup(QPoint(100,100))
res = app.exec_()
sys.exit(res)
Forget my last comment, it's not the real issue...

Let's look at this code:
#!/usr/bin/python2
# -*- coding: utf-8 -*-
import sys
from PyQt4.QtGui import QApplication, QErrorMessage
from PyQt4.QtCore import *
from PyQt4.QtGui import *
import thread
import time

def hide():
print "HIDE"
sys.exit()

if __name__ == '__main__':
app = QApplication(sys.argv)
menu = QMenu()
menu.addAction("plop")
menu.addAction("plop")
menu.addAction("plop")
menu.addAction("plop")
menu.popup(QPoint(100,100))
menu.aboutToHide.connect(hide)
res = app.exec_()
sys.exit(res)

If you run:
$ sleep 2 && python2 test.py

and click anywhere on any application, menu popup will not get keyboard/mouse "focus"... It's the issue i have in kded-module.

Klipper while calling popup menu with global shortcut do not have this issue and i can't understand why when looking at source code.


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18156
-----------------------------------------------------------
Post by Thomas Lübking
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 27, 2012, 2:02 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-08-31 09:55:02 UTC
Permalink
Post by Thomas Lübking
Post by Bellegarde Cédric
Ok more information about QMenu focus issue...
Kded-appmenu do not have any bug with this, when calling showMenu with qdbus, it's working...
The bug seems to be in this patch but don't know why... Like if kwin was grabing mouse+keyboard while a button is pressed, is this true ?
don`t think so, but qabstactbutton likely will - and kcommondecorationbutton is one
I've looked at qabstractbutton code and can't find any mouse+keyboard grabing...
It seems that kwin while buttons clicked do not accept focus change from clients.
I try to connect appMenuButtonPressed() to released() signal with no luck.
Showing menu when it become available (so without click) works.
Help is really welcome.
this is not about focus at all - popups _never_ get the focus but gain it for server exclusive input handling (ie. grabbing input)
when attempting the grabfailing input event, check for qDebug() << QWidget::mouseGrabber() to see what currently has the mouse.
If there's none, kwin is not the issue (and pot. not even input grabbing)
Ok, it seems that QMenu only grabs input on fist show() but fails on laters...
This python code show issue. First time menu is shown, input is grabbed, second time it fails...
Is this a Qt Bug or am i missing something ?
#!/usr/bin/python2
# -*- coding: utf-8 -*-
import sys
from PyQt4.QtGui import QApplication, QErrorMessage
from PyQt4.QtCore import *
from PyQt4.QtGui import *
import thread
import time
app = QApplication(sys.argv)
menu = QMenu()
menu.addAction("plop")
menu.addAction("plop")
menu.addAction("plop")
menu.addAction("plop")
menu.popup(QPoint(100,100))
time.sleep(5)
menu.hide()
time.sleep(5)
menu.popup(QPoint(100,100))
res = app.exec_()
sys.exit(res)
Forget my last comment, it's not the real issue...
#!/usr/bin/python2
# -*- coding: utf-8 -*-
import sys
from PyQt4.QtGui import QApplication, QErrorMessage
from PyQt4.QtCore import *
from PyQt4.QtGui import *
import thread
import time
print "HIDE"
sys.exit()
app = QApplication(sys.argv)
menu = QMenu()
menu.addAction("plop")
menu.addAction("plop")
menu.addAction("plop")
menu.addAction("plop")
menu.popup(QPoint(100,100))
menu.aboutToHide.connect(hide)
res = app.exec_()
sys.exit(res)
$ sleep 2 && python2 test.py
and click anywhere on any application, menu popup will not get keyboard/mouse "focus"... It's the issue i have in kded-module.
Klipper while calling popup menu with global shortcut do not have this issue and i can't understand why when looking at source code.
Ok, find a solution in qlipper source code... This issue is fixed.


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18156
-----------------------------------------------------------
Post by Thomas Lübking
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 27, 2012, 2:02 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Thomas Lübking
2012-08-31 10:00:50 UTC
Permalink
Post by Thomas Lübking
Post by Bellegarde Cédric
Ok more information about QMenu focus issue...
Kded-appmenu do not have any bug with this, when calling showMenu with qdbus, it's working...
The bug seems to be in this patch but don't know why... Like if kwin was grabing mouse+keyboard while a button is pressed, is this true ?
don`t think so, but qabstactbutton likely will - and kcommondecorationbutton is one
I've looked at qabstractbutton code and can't find any mouse+keyboard grabing...
It seems that kwin while buttons clicked do not accept focus change from clients.
I try to connect appMenuButtonPressed() to released() signal with no luck.
Showing menu when it become available (so without click) works.
Help is really welcome.
this is not about focus at all - popups _never_ get the focus but gain it for server exclusive input handling (ie. grabbing input)
when attempting the grabfailing input event, check for qDebug() << QWidget::mouseGrabber() to see what currently has the mouse.
If there's none, kwin is not the issue (and pot. not even input grabbing)
Ok, it seems that QMenu only grabs input on fist show() but fails on laters...
This python code show issue. First time menu is shown, input is grabbed, second time it fails...
Is this a Qt Bug or am i missing something ?
#!/usr/bin/python2
# -*- coding: utf-8 -*-
import sys
from PyQt4.QtGui import QApplication, QErrorMessage
from PyQt4.QtCore import *
from PyQt4.QtGui import *
import thread
import time
app = QApplication(sys.argv)
menu = QMenu()
menu.addAction("plop")
menu.addAction("plop")
menu.addAction("plop")
menu.addAction("plop")
menu.popup(QPoint(100,100))
time.sleep(5)
menu.hide()
time.sleep(5)
menu.popup(QPoint(100,100))
res = app.exec_()
sys.exit(res)
Forget my last comment, it's not the real issue...
#!/usr/bin/python2
# -*- coding: utf-8 -*-
import sys
from PyQt4.QtGui import QApplication, QErrorMessage
from PyQt4.QtCore import *
from PyQt4.QtGui import *
import thread
import time
print "HIDE"
sys.exit()
app = QApplication(sys.argv)
menu = QMenu()
menu.addAction("plop")
menu.addAction("plop")
menu.addAction("plop")
menu.addAction("plop")
menu.popup(QPoint(100,100))
menu.aboutToHide.connect(hide)
res = app.exec_()
sys.exit(res)
$ sleep 2 && python2 test.py
and click anywhere on any application, menu popup will not get keyboard/mouse "focus"... It's the issue i have in kded-module.
Klipper while calling popup menu with global shortcut do not have this issue and i can't understand why when looking at source code.
Ok, find a solution in qlipper source code... This issue is fixed.
For the records:

The first test doesn't first show a menu at all. When it does, it does not grab the pointer and even if i close the menu (click a plopp) the code does not exit (and cannot be ctrl+c'd either)

The second test works as expected. I cannot prevent the menu from grabbing the pointer by passing the focus somewhere else and/or click any window.


In general i'd be careful about python for testing on this for the popup requires input grabbing (most evil X11 feature) and the python module may have special protections against abuse (or coding failure)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18156
-----------------------------------------------------------
Post by Thomas Lübking
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 27, 2012, 2:02 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-08-31 13:45:54 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated Aug. 31, 2012, 1:45 p.m.)


Review request for kwin.


Changes
-------

- Move menu availability cache to client as kcommondecoration is destroyed on button re-positioning
- Add support for showRequest kded-appmenu signal for better menu placement when menu requested by application


Description
-------

Here a patch to add appmenu support to kwin via a menu button in titlebar

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

It looks like this:
http://youtu.be/x1bm7Q6_SH4

New version, all drawing code moved to kded-appmenu as asked.


Diffs (updated)
-----

kwin/kcmkwin/kwindecoration/preview.h 52645fd
kwin/kcmkwin/kwindecoration/preview.cpp 587df7c
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/bridge.h 64108e5
kwin/bridge.cpp 32d4c84
kwin/client.h f31707b
kwin/client.cpp c541595
kcontrol/style/finetuning.ui 2d384bc
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Martin Gräßlin
2012-09-02 07:57:12 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18423
-----------------------------------------------------------



kwin/CMakeLists.txt
<http://git.reviewboard.kde.org/r/104344/#comment14532>

Here you could also use CMAKE_DEPENDENT_OPTION to define that the option depends on KWIN_BUILD_DECORATIONS. Might be cleaner



kwin/client.h
<http://git.reviewboard.kde.org/r/104344/#comment14533>

trailing whitespaces



kwin/client.cpp
<http://git.reviewboard.kde.org/r/104344/#comment14534>

needs also an ifdef block as it's ifdef'ed in the header. Watch the whitespaces after comma



kwin/client.cpp
<http://git.reviewboard.kde.org/r/104344/#comment14535>

sure that you want to emit prior to update the variable? Any slot connecting to appMenuAvailable and asking whether the app menu is available will get a wrong result



kwin/clients/oxygen/oxygenbutton.h
<http://git.reviewboard.kde.org/r/104344/#comment14538>

I think the decorations should neither include the config-kwin.h nor make the build conditional. The library is not conditional so everything should be runtime.

And it has to be that way, because it is no requirement for decorations to be in the KWin directory (some are in kde-artwork)



kwin/libkdecorations/kcommondecoration.h
<http://git.reviewboard.kde.org/r/104344/#comment14539>

the button has to be moved after ShadeButton that is the last one before NumButtons. Otherwise decorations compiled against an old version break.



kwin/libkdecorations/kcommondecoration.cpp
<http://git.reviewboard.kde.org/r/104344/#comment14540>

the library should not use be built conditional



kwin/libkdecorations/kcommondecoration.cpp
<http://git.reviewboard.kde.org/r/104344/#comment14541>

trailing whitespace



kwin/libkdecorations/kdecoration.h
<http://git.reviewboard.kde.org/r/104344/#comment14543>

any particular reason why you added the new methods to the Unstable subclass and not to KDecoration directly? It doesn't seem to require anything from the Unstable API and seems ABI stable to me



kwin/libkdecorations/kdecoration.cpp
<http://git.reviewboard.kde.org/r/104344/#comment14542>

does the DBus really need to be inside the decoration library? Can't we handle that from inside the core?



kwin/workspace.cpp
<http://git.reviewboard.kde.org/r/104344/#comment14536>

if (Client *c = findClient(...)) {
c->emitShowRequest();
}



kwin/workspace.cpp
<http://git.reviewboard.kde.org/r/104344/#comment14537>

foreach (Client *c, clients) {
....
}


- Martin GrÀßlin
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 31, 2012, 1:45 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kwin/kcmkwin/kwindecoration/preview.h 52645fd
kwin/kcmkwin/kwindecoration/preview.cpp 587df7c
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/bridge.h 64108e5
kwin/bridge.cpp 32d4c84
kwin/client.h f31707b
kwin/client.cpp c541595
kcontrol/style/finetuning.ui 2d384bc
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-09-03 07:54:40 UTC
Permalink
Post by Bellegarde Cédric
kwin/CMakeLists.txt, lines 32-34
<http://git.reviewboard.kde.org/r/104344/diff/17/?file=82475#file82475line32>
Here you could also use CMAKE_DEPENDENT_OPTION to define that the option depends on KWIN_BUILD_DECORATIONS. Might be cleaner
CMAKE_DEPENDENT_OPTION(KWIN_BUILD_KAPPMENU "Build without appmenu support" FALSE "KWIN_BUILD_DECORATIONS" FALSE)

First is this good ?

I've add this but it tell me:
Unknown Cmake command "CMAKE_DEPENDENT_OPTION"


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18423
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 31, 2012, 1:45 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kwin/kcmkwin/kwindecoration/preview.h 52645fd
kwin/kcmkwin/kwindecoration/preview.cpp 587df7c
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/bridge.h 64108e5
kwin/bridge.cpp 32d4c84
kwin/client.h f31707b
kwin/client.cpp c541595
kcontrol/style/finetuning.ui 2d384bc
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-09-03 09:51:05 UTC
Permalink
Post by Bellegarde Cédric
kwin/CMakeLists.txt, lines 32-34
<http://git.reviewboard.kde.org/r/104344/diff/17/?file=82475#file82475line32>
Here you could also use CMAKE_DEPENDENT_OPTION to define that the option depends on KWIN_BUILD_DECORATIONS. Might be cleaner
CMAKE_DEPENDENT_OPTION(KWIN_BUILD_KAPPMENU "Build without appmenu support" FALSE "KWIN_BUILD_DECORATIONS" FALSE)
First is this good ?
Unknown Cmake command "CMAKE_DEPENDENT_OPTION"
Ok, got it, i'm a cmake noob :-/


- Bellegarde


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18423
-----------------------------------------------------------
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Aug. 31, 2012, 1:45 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kwin/kcmkwin/kwindecoration/preview.h 52645fd
kwin/kcmkwin/kwindecoration/preview.cpp 587df7c
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.h 98e60cc
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/bridge.h 64108e5
kwin/bridge.cpp 32d4c84
kwin/client.h f31707b
kwin/client.cpp c541595
kcontrol/style/finetuning.ui 2d384bc
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-09-03 10:35:44 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated Sept. 3, 2012, 10:35 a.m.)


Review request for kwin.


Changes
-------

Fix last issues pointed by Martin GrÀßlin


Description
-------

Here a patch to add appmenu support to kwin via a menu button in titlebar

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

It looks like this:
http://youtu.be/x1bm7Q6_SH4

New version, all drawing code moved to kded-appmenu as asked.


Diffs (updated)
-----

kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt ce69e84
kwin/bridge.h 64108e5
kwin/bridge.cpp 32d4c84
kwin/client.h f31707b
kwin/client.cpp c541595
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 52645fd
kwin/kcmkwin/kwindecoration/preview.cpp 587df7c
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp 13a4c49
kwin/libkdecorations/kdecoration.h 614b902
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/useractions.cpp a501782
kwin/workspace.h 16630f7
kwin/workspace.cpp cf3f308

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Bellegarde Cédric
2012-09-10 13:12:56 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated Sept. 10, 2012, 1:12 p.m.)


Review request for kwin.


Changes
-------

Sync options name with kded-appmenu (code cleanup for kde inclusion)


Description
-------

Here a patch to add appmenu support to kwin via a menu button in titlebar

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

It looks like this:
http://youtu.be/x1bm7Q6_SH4

New version, all drawing code moved to kded-appmenu as asked.


Diffs (updated)
-----

kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt b65d5ee
kwin/bridge.h 64108e5
kwin/bridge.cpp 6dbf1bd
kwin/client.h c9dd109
kwin/client.cpp 7740785
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 0b39d7d
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 52645fd
kwin/kcmkwin/kwindecoration/preview.cpp 587df7c
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp e3e884b
kwin/libkdecorations/kdecoration.h 7b1f3e0
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/useractions.cpp 8fcdba2
kwin/workspace.h c4fd281
kwin/workspace.cpp 258a237

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Bellegarde Cédric
2012-09-14 13:47:47 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18975
-----------------------------------------------------------


Is there any particular action to do for kded-appmenu integration in KDE ?

I send a mail on the list but is this the good way to do ?

- Bellegarde Cédric
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Sept. 10, 2012, 1:12 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt b65d5ee
kwin/bridge.h 64108e5
kwin/bridge.cpp 6dbf1bd
kwin/client.h c9dd109
kwin/client.cpp 7740785
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 0b39d7d
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 52645fd
kwin/kcmkwin/kwindecoration/preview.cpp 587df7c
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp e3e884b
kwin/libkdecorations/kdecoration.h 7b1f3e0
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/useractions.cpp 8fcdba2
kwin/workspace.h c4fd281
kwin/workspace.cpp 258a237
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-09-26 12:51:42 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated Sept. 26, 2012, 12:51 p.m.)


Review request for kwin.


Changes
-------

Check for appmenu-qt and show suitable message if unavailable.


Description
-------

Here a patch to add appmenu support to kwin via a menu button in titlebar

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

It looks like this:
http://youtu.be/x1bm7Q6_SH4

New version, all drawing code moved to kded-appmenu as asked.


Diffs (updated)
-----

kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt 458c341
kwin/bridge.h 64108e5
kwin/bridge.cpp 6dbf1bd
kwin/client.h 130a67a
kwin/client.cpp fefdb40
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 0b39d7d
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 52645fd
kwin/kcmkwin/kwindecoration/preview.cpp 587df7c
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp e3e884b
kwin/libkdecorations/kdecoration.h 7b1f3e0
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/useractions.cpp 8fcdba2
kwin/workspace.h c4fd281
kwin/workspace.cpp 5b37aee

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric
Bellegarde Cédric
2012-10-03 09:15:31 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review19814
-----------------------------------------------------------


kded-appmenu has been commited to kde-workspace, need a ship it to commit this patch.

- Bellegarde Cédric
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Sept. 26, 2012, 12:51 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt 458c341
kwin/bridge.h 64108e5
kwin/bridge.cpp 6dbf1bd
kwin/client.h 130a67a
kwin/client.cpp fefdb40
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 0b39d7d
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 52645fd
kwin/kcmkwin/kwindecoration/preview.cpp 587df7c
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp e3e884b
kwin/libkdecorations/kdecoration.h 7b1f3e0
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/useractions.cpp 8fcdba2
kwin/workspace.h c4fd281
kwin/workspace.cpp 5b37aee
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Martin Gräßlin
2012-10-03 15:52:45 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review19837
-----------------------------------------------------------


I just enabled it on my system and have two small suggestions:

* when enabling in the style menu add a note that it only affects newly started applications
* automatically add the application button to KWin button configuration when selecting the in decoration setting

- Martin GrÀßlin
Post by Bellegarde Cédric
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------
(Updated Sept. 26, 2012, 12:51 p.m.)
Review request for kwin.
Description
-------
Here a patch to add appmenu support to kwin via a menu button in titlebar
Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/
http://quickgit.kde.org/index.php?p=kded-appmenu.git
http://youtu.be/x1bm7Q6_SH4
New version, all drawing code moved to kded-appmenu as asked.
Diffs
-----
kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt 458c341
kwin/bridge.h 64108e5
kwin/bridge.cpp 6dbf1bd
kwin/client.h 130a67a
kwin/client.cpp fefdb40
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 0b39d7d
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 52645fd
kwin/kcmkwin/kwindecoration/preview.cpp 587df7c
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp e3e884b
kwin/libkdecorations/kdecoration.h 7b1f3e0
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/useractions.cpp 8fcdba2
kwin/workspace.h c4fd281
kwin/workspace.cpp 5b37aee
Diff: http://git.reviewboard.kde.org/r/104344/diff/
Testing
-------
Thanks,
Bellegarde Cédric
Bellegarde Cédric
2012-10-04 11:27:12 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/
-----------------------------------------------------------

(Updated Oct. 4, 2012, 11:27 a.m.)


Review request for kwin.


Changes
-------

- Show message to user when switching from "In Application" option
- Auto add application menu button if needed


Description
-------

Here a patch to add appmenu support to kwin via a menu button in titlebar

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

It looks like this:
http://youtu.be/x1bm7Q6_SH4

New version, all drawing code moved to kded-appmenu as asked.


Diffs (updated)
-----

kcontrol/style/finetuning.ui 2d384bc
kcontrol/style/kcmstyle.h cd1472f
kcontrol/style/kcmstyle.cpp 849a49b
kwin/CMakeLists.txt 458c341
kwin/bridge.h 64108e5
kwin/bridge.cpp 6dbf1bd
kwin/client.h 130a67a
kwin/client.cpp 07ffe03
kwin/clients/oxygen/oxygenbutton.h ea11717
kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
kwin/clients/oxygen/oxygenclient.cpp 0b39d7d
kwin/clients/oxygen/oxygenfactory.h b38b097
kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
kwin/config-kwin.h.cmake e5ed2a6
kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
kwin/kcmkwin/kwindecoration/preview.h 52645fd
kwin/kcmkwin/kwindecoration/preview.cpp 587df7c
kwin/libkdecorations/kcommondecoration.h 3fe9fcf
kwin/libkdecorations/kcommondecoration.cpp e3e884b
kwin/libkdecorations/kdecoration.h 7b1f3e0
kwin/libkdecorations/kdecoration.cpp 71f4f8d
kwin/libkdecorations/kdecorationbridge.h b7d0619
kwin/useractions.cpp 8fcdba2
kwin/workspace.h c4fd281
kwin/workspace.cpp e86e39e

Diff: http://git.reviewboard.kde.org/r/104344/diff/


Testing
-------


Thanks,

Bellegarde Cédric

Continue reading on narkive:
Loading...