Discussion:
D17386: [autotests] Fix failing of testDontCrashReinitializeCompositor
Vlad Zagorodniy
2018-12-06 17:30:53 UTC
Permalink
zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
Currently, testDontCrashReinitializeCompositor is unstable because it
doesn't take into account that effects can be loaded asynchronously.

In general, we don't need all default effects in this test, so let's
disable them.

TEST PLAN
This should fix ASan issues.

REPOSITORY
R108 KWin

BRANCH
fix-dont-crash-reinitialize-compositor

REVISION DETAIL
https://phabricator.kde.org/D17386

AFFECTED FILES
autotests/integration/dont_crash_reinitialize_compositor.cpp

To: zzag, #kwin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
David Edmundson
2018-12-06 17:41:52 UTC
Permalink
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
R108 KWin

BRANCH
fix-dont-crash-reinitialize-compositor

REVISION DETAIL
https://phabricator.kde.org/D17386

To: zzag, #kwin, davidedmundson
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
Vlad Zagorodniy
2018-12-06 17:42:30 UTC
Permalink
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:3956d6ab4a4e: [autotests] Fix failing of testDontCrashReinitializeCompositor (authored by zzag).

REPOSITORY
R108 KWin

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17386?vs=46976&id=46979

REVISION DETAIL
https://phabricator.kde.org/D17386

AFFECTED FILES
autotests/integration/dont_crash_reinitialize_compositor.cpp

To: zzag, #kwin, davidedmundson
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
Loading...